Uh oh!
There was an error while loading. Please reload this page.
Disable timeouts using timeout=False - #490
Closed
florimondmanca wants to merge 1 commit into
Closed
Conversation
florimondmanca
commented
Oct 20, 2019
ContributorAuthor
It might be possible to split this PR in two: 1) make |
This was referenced Oct 20, 2019
Closed
florimondmancaforce-pushed
the
feat/disable-timeouts
branch
from
October 20, 2019 12:42
707e284 to
b7ac18eCompareflorimondmancaforce-pushed
the
feat/disable-timeouts
branch
from
October 20, 2019 12:45
b7ac18e to
01e1e97Compareflorimondmancaforce-pushed
the
feat/disable-timeouts
branch
from
October 20, 2019 12:50
01e1e97 to
ee39d90Compareflorimondmanca
commented
Oct 20, 2019
ContributorAuthor
Closed in favor of #493. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433, alternative for #463 (cc @jcugat).
Essentially, this PR proposes the following behaviors:
timeout=None(or not passing atimeout) uses the default timeout, always. (This is a breaking change compared to the current situation in which e.g.Client(timeout=None)disables timeouts.)timeout=Falsedisables timeouts, always.This leads us to have a consistent behavior for timeout values across entrypoints and clients. This also allows us to keep the footprint of the change minimal (as opposed to #463).
I updated the docs to be very explicit and illustrative on all these cases.
I do believe that
timeout=Noneis not the most intuitive API to expose to our users, but my logic here is that usingtimeout=False(as in "Don't timeout!") is merely a matter of getting used to it.