Uh oh!
There was an error while loading. Please reload this page.
Reorganize timeout config tests - #491
Merged
Merged
Conversation
lovelydinosaur
commented
Oct 22, 2019
Contributor
Happy enough with this, sure. |
florimondmanca
commented
Oct 22, 2019
ContributorAuthor
Exactly — this PR explicits the current behavior we have so that we can potentially adapt it when fixing #433. :) |
Kludex referenced
this pull request
in pydantic/httpx2
May 11, 2026
…#491) * Use 'socks5://' for the protocol in SOCKS proxy docs. Not 'socks://' * Defensive programming around removing request status from the connection pool * Tighten up behaviour around exceptions during streaming responses * Call response_closed on async cancellations, KeyboardInterupts * Include number of requests in-flight in exception if pool is closed early * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bit of moving timeout config tests around so they're all close to one another, and add one or two tests for the default cases. Would help reduce the scope of #490.