Skip to content

Brush up response deprecations - #671

Closed
florimondmanca wants to merge 2 commits into
masterfrom
response-deprecations
Closed

Brush up response deprecations#671
florimondmanca wants to merge 2 commits into
masterfrom
response-deprecations

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented Dec 21, 2019

Copy link
Copy Markdown
Contributor

Refs #667

  • Deprecate .read() in favor of .aread().
  • Deprecate .close() in favor of .aclose().
  • Use the DeprecationWarning category for all deprecation-related warnings on Response.
  • Add a test for deprecated Response methods.

@florimondmancaflorimondmanca added the refactor Issues and PRs related to code refactoring label Dec 21, 2019
@florimondmanca
florimondmanca requested a review from a teamDecember 21, 2019 15:50
@florimondmanca
florimondmanca deleted the response-deprecations branch December 21, 2019 16:21
@florimondmanca

florimondmanca commented Dec 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Closed in favor of #674.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactorIssues and PRs related to code refactoring

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@florimondmanca