Skip to content

Rename 'read/close' to 'aread/aclose' on Response - #674

Merged
lovelydinosaur merged 3 commits into
masterfrom
response-aread-aclose
Dec 29, 2019
Merged

Rename 'read/close' to 'aread/aclose' on Response#674
lovelydinosaur merged 3 commits into
masterfrom
response-aread-aclose

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented Dec 21, 2019

Copy link
Copy Markdown
Contributor

Refs #667

@florimondmancaflorimondmanca added the api change PRs that contain breaking public API changes label Dec 21, 2019
@florimondmanca
florimondmanca requested a review from a teamDecember 21, 2019 16:22
@florimondmancaflorimondmanca mentioned this pull request Dec 21, 2019
Closed
@florimondmancaflorimondmanca changed the title Switch to aread/aclose on ResponseRename 'read/close' to 'aread/aclose' on ResponseDec 21, 2019
@lovelydinosaurlovelydinosaur added this to the 0.10.0 milestone Dec 23, 2019
@lovelydinosaurlovelydinosaur mentioned this pull request Dec 29, 2019
Merged
@lovelydinosaur
lovelydinosaur merged commit f9d18a8 into masterDec 29, 2019
@lovelydinosaur
lovelydinosaur deleted the response-aread-aclose branch December 29, 2019 15:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur approved these changes

Assignees

No one assigned

Labels

api changePRs that contain breaking public API changes

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@lovelydinosaur