Skip to content

Transport API - #963

Merged
yeraydiazdiaz merged 16 commits into
encode:masterfrom
yeraydiazdiaz:transport-api
May 21, 2020
Merged

Transport API#963
yeraydiazdiaz merged 16 commits into
encode:masterfrom
yeraydiazdiaz:transport-api

Conversation

@yeraydiazdiaz

@yeraydiazdiazyeraydiazdiaz commented May 20, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Closeshttps://github.com/encode/httpx/issues/768

I did some dispatch > transport renaming but did not rename the _dispatch package and the *Dispatch classes in it. I considered renaming the package to _transports and all classes to *Transport with *Dispatch aliases but thought it might be better to check first.

Edit: Pipelines failed for some reason so I went for it while I gave GH actions some time to sort themselves out.

@yeraydiazdiaz
yeraydiazdiaz requested a review from a teamMay 20, 2020 14:39
Yeray Diaz Diaz
_dispatch > _transports
82faccb
Also rename *Dispatch classes to *Transport and added aliases
@yeraydiazdiaz

yeraydiazdiaz commented May 20, 2020

Copy link
Copy Markdown
ContributorAuthor

Hmmm, not sure what's going on here, all checks are "cancelled" and there's no log at all so I guess I'll try again later 🤷‍♂️

lovelydinosaur
lovelydinosaur reviewed May 20, 2020
View reviewed changes

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab yup! A few notes. Looking great. 👍

Comment threadhttpx/__init__.py Outdated
Comment threaddocs/advanced.md Outdated
Comment threadhttpx/_client.py Outdated
@lovelydinosaur

lovelydinosaur commented May 20, 2020

Copy link
Copy Markdown
Contributor

Looks like a linter failure on import sorting... https://github.com/encode/httpx/pull/963/checks?check_run_id=693477366

JayH5
JayH5 reviewed May 20, 2020
View reviewed changes
Comment threaddocs/advanced.md Outdated
JayH5
JayH5 reviewed May 20, 2020
View reviewed changes
Comment threadhttpx/_client.py Outdated
florimondmanca
florimondmanca previously requested changes May 21, 2020
View reviewed changes

@florimondmancaflorimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I assume the docs would need updating too - we're still using the Dispatch phrasing there as of the current state of this PR. Do we want to update it in this PR or as a follow-up?

Comment threaddocs/advanced.md Outdated
Comment threaddocs/advanced.md Outdated
Comment threadhttpx/_client.py Outdated
Comment threadhttpx/_transports/wsgi.py Outdated
Yeray Diaz Diaz@florimondmanca
Update docs/advanced.md
9aae0b8
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
@florimondmancaflorimondmanca mentioned this pull request May 21, 2020
Closed
@yeraydiazdiaz

yeraydiazdiaz commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

I assume the docs would need updating too - we're still using the Dispatch phrasing there as of the current state of this PR. Do we want to update it in this PR or as a follow-up?

Probably best to change the docs now, there's quite a few code snippets using Dispatch as well.

lovelydinosaur
lovelydinosaur reviewed May 21, 2020
View reviewed changes
Comment threaddocs/advanced.md Outdated
lovelydinosaur
lovelydinosaur approved these changes May 21, 2020
View reviewed changes

@lovelydinosaurlovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this whenever you are! Fantastic bit of work and really keen to see this land!

@lovelydinosaur

lovelydinosaur commented May 21, 2020

Copy link
Copy Markdown
Contributor

Great, once everyone's happy let's get this in as it is.

Couple of follow ups I can think of, which I'll open individual issues for.

@lovelydinosaurlovelydinosaur added this to the v0.13 milestone May 21, 2020
@yeraydiazdiaz
yeraydiazdiaz merged commit d2816c9 into encode:masterMay 21, 2020
@yeraydiazdiaz
yeraydiazdiaz deleted the transport-api branch May 21, 2020 11:22
@yeraydiazdiaz

yeraydiazdiaz commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks all! 🎉

@lovelydinosaurlovelydinosaur mentioned this pull request May 21, 2020
Merged
@hugovkhugovk mentioned this pull request Mar 5, 2024
Merged
1 task
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
@zrquan
Use new typing style (#963)
680cb20
* Use new typing style
* Pass all checks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaurlovelydinosaurlovelydinosaur approved these changes
@florimondmancaflorimondmancaAwaiting requested review from florimondmanca
+1 more reviewer
@JayH5JayH5JayH5 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

v0.13

Development

Successfully merging this pull request may close these issues.

Transport API

4 participants

@yeraydiazdiaz@lovelydinosaur@JayH5@florimondmanca