Skip to content

Introduce a warn_deprecated helper - #964

Closed
florimondmanca wants to merge 1 commit into
masterfrom
warn-deprecated
Closed

Introduce a warn_deprecated helper#964
florimondmanca wants to merge 1 commit into
masterfrom
warn-deprecated

Conversation

@florimondmanca

@florimondmancaflorimondmanca commented May 21, 2020

Copy link
Copy Markdown
Contributor

Description
Add a warn_deprecated() util meant to be used to notify users that they're following a deprecated code path.

Motivation
The DeprecationWarning category is necessary for Python to facilitate the filtering of these warnings, but it's easy to forget - see #963 (comment)

@florimondmancaflorimondmanca added the refactor Issues and PRs related to code refactoring label May 21, 2020
@florimondmancaflorimondmanca mentioned this pull request May 21, 2020
@yeraydiazdiaz

Copy link
Copy Markdown
Contributor

Awkward... d876de8 😅

@florimondmanca

florimondmanca commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Sure! I thought we might as well merge this and then rebase #963 on top of master - for the sake of separation… Either way works fine!

@florimondmanca
florimondmanca deleted the warn-deprecated branch May 21, 2020 08:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactorIssues and PRs related to code refactoring

Development

Successfully merging this pull request may close these issues.

2 participants

@florimondmanca@yeraydiazdiaz