Skip to content

fixes javadoc plugin issue - #158

Merged
jakubdyszkiewicz merged 1 commit into
envoyproxy:masterfrom
listaction:fix/mvn-plugins
Dec 25, 2020
Merged

fixes javadoc plugin issue#158
jakubdyszkiewicz merged 1 commit into
envoyproxy:masterfrom
listaction:fix/mvn-plugins

Conversation

@listaction

@listactionlistaction commented Dec 24, 2020

Copy link
Copy Markdown
Contributor
fixes:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on project api: Execution attach-javadocs of goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar failed: Cannot invoke "org.apache.commons.lang3.JavaVersion.atLeast(org.apache.commons.lang3.JavaVersion)" because "org.apache.commons.lang3.SystemUtils.JAVA_SPECIFICATION_VERSION_AS_ENUM" is null -> on java8+
additionally bumped up jacoco plugin version.

@listaction
fixes javadoc and jacoco plugin issues
4bab77f
Signed-off-by: karthik <listaction@gmail.com>
@codecov-io

codecov-io commented Dec 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #158 (4bab77f) into master (ff834cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #158 +/- ##
=========================================
Coverage 88.22% 88.22% Complexity 298 298 =========================================
Files 31 31 Lines 977 977 Branches 78 78 =========================================
Hits 862 862 Misses 85 85 Partials 30 30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff834cb...4bab77f. Read the comment docs.

@jakubdyszkiewicz
jakubdyszkiewicz merged commit f58b198 into envoyproxy:masterDec 25, 2020
slonka pushed a commit that referenced this pull request May 20, 2021
@listaction@slonka
ci: fixes javadoc and jacoco plugin issues (#158)
6197daa
Signed-off-by: karthik <listaction@gmail.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Ferdudas97 added a commit that referenced this pull request Sep 9, 2022
@slonka@sschepens
mgajda@wookieJ@envoy-bot@listactionŁukasz Dziedziak@Ferdudas97
Delta XDS - improved (#166)
f54d234
* delta xds
Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* fixes
Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* method naming
Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Building version of non-breaking changes
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Get integration tests passing
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Add delta tests back
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Rewrite V3DiscoveryServerAdsDeltaResourcesIT to have a 2 second poll delay to account for potential delays in writing to the wire (we don't want that to happen)
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Add comment to trigger PR build
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Get V3DiscoveryServerXdsDeltaResourcesIT passing
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Update protobuf to envoy 1.16.0 (#155)
* Update protobuf to envoy 1.16.0
Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>
* Fixing test by setting -boostrap-version 2 flag
Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>
* Update protobuf to envoy 1.16.0
Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl>
* Information about update envoy image version in README.md
Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare release v0.1.25
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare for next development iteration
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare release v0.1.26
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare for next development iteration
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Bump nexus release plugin timeout to 20 minutes (#156)
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare release v0.1.27
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare for next development iteration
Signed-off-by: slonka <slonka@users.noreply.github.com>
* ci: fixes javadoc and jacoco plugin issues (#158)
Signed-off-by: karthik <listaction@gmail.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Update api to v1 17 (#159)
* Update protobuf to envoy 1.17
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
* Use v2 version
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
* Support V2/V3 in Envoy - remove V2 in separate PR
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
* UDPA download - split directory create/copy
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Fix references to main branch after rename (#160)
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare release v0.1.28
Signed-off-by: slonka <slonka@users.noreply.github.com>
* release: prepare for next development iteration
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Change version to 0.1.29-delta-xds-slonka-SNAPSHOT
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Revert ads configs to main
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Hash bytes array not string
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Remove unused import
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Revert snapshot name
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Remove respondDeltaTracked since it's not used anywhere
Signed-off-by: slonka <slonka@users.noreply.github.com>
* Delta xds non breaking hash bytes refactor (#181)
* refactor delta xds
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* refactor setDeltaWatch and remove code duplication
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* resolve TODO in SnapshotTest
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* Change version to 0.1.29-delta-xds-slonka-SNAPSHOT
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* DEPLOY_BRANCH added for snapshot deploy
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* changes after merge master with new envoy api
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* make CacheStatusInfoAggregator public
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* make GroupCacheStatusInfo and MutableStatusInfo public
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* refactor SimpleCache
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* create resources map only once
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* build snapshot with improved performance
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* refactor creating snapshot resources due to performance improvements
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* create hash version from string
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* remove custom snapshot version and deploy branch env
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* fix test after merge
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
* fix V3DeltaDiscoveryServerCallbacks description
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com>
Signed-off-by: karthik <listaction@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Co-authored-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com>
Co-authored-by: mgajda <mgajda@hubspot.com>
Co-authored-by: Łukasz Jędryczka <34069409+wookieJ@users.noreply.github.com>
Co-authored-by: envoy-bot <envoy-bot@users.noreply.github.com>
Co-authored-by: Karthik Ram <listaction@gmail.com>
Co-authored-by: Łukasz Dziedziak <lukasz.dziedziak@allegro.pl>
Co-authored-by: Radek Chrzanowski <ferdudas97@gmail.com>
Co-authored-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jakubdyszkiewiczjakubdyszkiewiczjakubdyszkiewicz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@listaction@codecov-io@jakubdyszkiewicz