Uh oh!
There was an error while loading. Please reload this page.
Delta xds non breaking hash bytes refactor - #181
Merged
Conversation
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
codecov-commenter
commented
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@## delta-xds-non-breaking-slonka-hash-bytes #181 +/- ##
==============================================================================
+ Coverage 80.61% 82.54% +1.93% + Complexity 428 426 -2
==============================================================================
Files 39 43 +4 Lines 1501 1467 -34 Branches 120 117 -3 ==============================================================================
+ Hits 1210 1211 +1 + Misses 224 192 -32 + Partials 67 64 -3
Continue to review full report at Codecov.
|
| AtomicIntegerFieldUpdater.newUpdater(AbstractWatch.class, "isCancelled"); | ||
| private final V request; | ||
| private final Consumer<T> responseConsumer; | ||
| private volatile int isCancelled = 0; |
ContributorAuthor
There was a problem hiding this comment.
it is used via isCancelledUpdater in cancel() and in isCancelled()
kukulam-allegro
approved these changes
Oct 18, 2021
kukulam-allegro
approved these changes
Oct 20, 2021
lukidzi
approved these changes
Oct 21, 2021
Ferdudas97 added a commit
that referenced
this pull request
Nov 18, 2021
* refactor delta xds Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * refactor setDeltaWatch and remove code duplication Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * resolve TODO in SnapshotTest Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
Ferdudas97 added a commit
that referenced
this pull request
Sep 9, 2022
* delta xds Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: slonka <slonka@users.noreply.github.com> * fixes Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: slonka <slonka@users.noreply.github.com> * method naming Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: slonka <slonka@users.noreply.github.com> * Building version of non-breaking changes Signed-off-by: slonka <slonka@users.noreply.github.com> * Get integration tests passing Signed-off-by: slonka <slonka@users.noreply.github.com> * Add delta tests back Signed-off-by: slonka <slonka@users.noreply.github.com> * Rewrite V3DiscoveryServerAdsDeltaResourcesIT to have a 2 second poll delay to account for potential delays in writing to the wire (we don't want that to happen) Signed-off-by: slonka <slonka@users.noreply.github.com> * Add comment to trigger PR build Signed-off-by: slonka <slonka@users.noreply.github.com> * Get V3DiscoveryServerXdsDeltaResourcesIT passing Signed-off-by: slonka <slonka@users.noreply.github.com> * Update protobuf to envoy 1.16.0 (#155) * Update protobuf to envoy 1.16.0 Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl> * Fixing test by setting -boostrap-version 2 flag Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl> * Update protobuf to envoy 1.16.0 Signed-off-by: Lukasz Jedryczka <lukasz.jedryczka@allegro.pl> * Information about update envoy image version in README.md Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com> Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare release v0.1.25 Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare for next development iteration Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare release v0.1.26 Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare for next development iteration Signed-off-by: slonka <slonka@users.noreply.github.com> * Bump nexus release plugin timeout to 20 minutes (#156) Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare release v0.1.27 Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare for next development iteration Signed-off-by: slonka <slonka@users.noreply.github.com> * ci: fixes javadoc and jacoco plugin issues (#158) Signed-off-by: karthik <listaction@gmail.com> Signed-off-by: slonka <slonka@users.noreply.github.com> * Update api to v1 17 (#159) * Update protobuf to envoy 1.17 Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl> * Use v2 version Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl> * Support V2/V3 in Envoy - remove V2 in separate PR Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl> * UDPA download - split directory create/copy Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl> Signed-off-by: slonka <slonka@users.noreply.github.com> * Fix references to main branch after rename (#160) Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare release v0.1.28 Signed-off-by: slonka <slonka@users.noreply.github.com> * release: prepare for next development iteration Signed-off-by: slonka <slonka@users.noreply.github.com> * Change version to 0.1.29-delta-xds-slonka-SNAPSHOT Signed-off-by: slonka <slonka@users.noreply.github.com> * Revert ads configs to main Signed-off-by: slonka <slonka@users.noreply.github.com> * Hash bytes array not string Signed-off-by: slonka <slonka@users.noreply.github.com> * Remove unused import Signed-off-by: slonka <slonka@users.noreply.github.com> * Revert snapshot name Signed-off-by: slonka <slonka@users.noreply.github.com> * Remove respondDeltaTracked since it's not used anywhere Signed-off-by: slonka <slonka@users.noreply.github.com> * Delta xds non breaking hash bytes refactor (#181) * refactor delta xds Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * refactor setDeltaWatch and remove code duplication Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * resolve TODO in SnapshotTest Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * Change version to 0.1.29-delta-xds-slonka-SNAPSHOT Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * DEPLOY_BRANCH added for snapshot deploy Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * changes after merge master with new envoy api Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * make CacheStatusInfoAggregator public Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * make GroupCacheStatusInfo and MutableStatusInfo public Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * refactor SimpleCache Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * create resources map only once Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * build snapshot with improved performance Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * refactor creating snapshot resources due to performance improvements Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * create hash version from string Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * remove custom snapshot version and deploy branch env Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * fix test after merge Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> * fix V3DeltaDiscoveryServerCallbacks description Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> Signed-off-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Signed-off-by: slonka <slonka@users.noreply.github.com> Signed-off-by: wookieJ <lukaszjedryczka.biuro@gmail.com> Signed-off-by: karthik <listaction@gmail.com> Signed-off-by: Lukasz Dziedziak <lukasz.dziedziak@allegro.pl> Signed-off-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl> Co-authored-by: Sebastian Schepens <sebastian.schepens@mercadolibre.com> Co-authored-by: mgajda <mgajda@hubspot.com> Co-authored-by: Łukasz Jędryczka <34069409+wookieJ@users.noreply.github.com> Co-authored-by: envoy-bot <envoy-bot@users.noreply.github.com> Co-authored-by: Karthik Ram <listaction@gmail.com> Co-authored-by: Łukasz Dziedziak <lukasz.dziedziak@allegro.pl> Co-authored-by: Radek Chrzanowski <ferdudas97@gmail.com> Co-authored-by: radoslaw.chrzanowski <radoslaw.chrzanowski@allegro.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.