Uh oh!
There was an error while loading. Please reload this page.
fix(release): run the Node 20 compat suite under bash on Windows - #2345
Merged
Conversation
Node 20 cannot expand a glob passed to `--test`, and PowerShell, the Windows runner's default shell, passes the pattern through literally, so the step failed with "Could not find ...\*.test.mjs" and kept the npm publish job skipped. Every other `node --test` glob in the workflows runs on Linux, where the shell expands it.
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | bashkit | 2851ce2 | Commit Preview URL Branch Preview URL | Aug 22 2026, 06:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Node 20 runtime-compat step in
publish-js.ymlnow runs withshell: bash.Why
With the Doppler token rotated and the ava/Node 20 gate in place (#2344), the dispatched
Publish JSrun got 21 of 22 jobs green — including every AI-example job — and stalled on one:Test JS on x86_64-pc-windows-msvc - node@20.Node 20 cannot expand a glob passed to
--test(that landed in Node 21), and PowerShell, the Windows runner's default shell, passes the pattern through literally. On Linux and macOS the defaultbashexpands it, which is why only the Windows leg failed. The neighbouring example step already pinsshell: bashfor the same reason.Release to NPMneeds every test job, so this one skipped job is all that still holds@everruns/bashkitat 0.16.0.Audited the other
node --testglob invocations while here: ci.yml (wasm + browser example), coverage.yml, js.yml, publish-wasm.yml, and the justfile all run on Linux, so none share the problem.Before / After
Before:
Test JS on x86_64-pc-windows-msvc - node@20fails on the literal pattern,Release to NPMis skipped, npm native stays at 0.16.0.After: the step runs under bash, which expands the glob before Node sees it — the same 163 runtime-compat tests the Linux and macOS Node 20 legs already pass.
Risk
shell:key in one workflow step; no change to what is executed.Checklist