Uh oh!
There was an error while loading. Please reload this page.
fix(test): mount a real temp dir in the JS runtime-compat suite - #2346
Merged
Conversation
The `mount and unmount` test mounted a hardcoded host `/tmp`, which does not exist on a Windows runner: `Invalid host_path '/tmp': The system cannot find the file specified`. The suite had only ever run on Linux, so publish-js running it on Windows Node 20 is what surfaced it, and the one red job kept the npm publish skipped. Mount a `mkdtemp` directory and clean it up, the way the ava vfs suite already does. Also records in the parity checker and the release-process knowledge that platform breadth is deliberately outside that check: the release workflows testing macOS and Windows is what caught this.
Deploying with |
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs | bashkit | 483b190 | Commit Preview URL Branch Preview URL | Aug 22 2026, 06:42 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The runtime-compat
mount and unmounttest mounts amkdtempdirectory (and removes it afterwards) instead of a hardcoded host/tmp, the way the avavfs.spec.tssuite already does.Why
With the glob fixed (#2345), the Windows Node 20 leg of
Publish JSran the suite for the first time and 162 of 163 tests passed. The one failure is a real portability bug in the test:/tmpis a host path here, not a VFS path — every other/tmpin this suite is inside the VFS and is fine anywhere. CI runs runtime-compat only onubuntu-latest, so nothing had ever mounted it from Windows.Release to NPMneeds every test job, so this single red job is what still holds@everruns/bashkitat 0.16.0.Also documents, in
scripts/check_workflow_parity.pyandknowledge/operations/release-process.md, that platforms are deliberately outside the parity check added in #2344: release workflows testing macOS and Windows where CI does not is extra coverage worth keeping, and it is exactly what surfaced this.Before / After
Before, on Windows Node 20:
After, locally on the same suite:
Risk
Checklist