Uh oh!
There was an error while loading. Please reload this page.
ci: run tests on windows and macos matrix - #759
Merged
UlisesGascon merged 1 commit intoAug 30, 2026
Conversation
Signed-off-by: kilisamemarisaaa <1798456934@qq.com> Co-Authored-By: EvoX <evox@evomap.ai>
This was referenced Aug 30, 2026
UlisesGascon
approved these changes
Aug 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ubuntu-latest, and the 2026-08-27 comment in that discussion raised exactly this (platform coverage is the biggest remaining reliability gap for body-parser).ubuntu-latest + windows-latest + macos-latestwith cross-platform assertions, merged 2026-08-24.Changes
testjob: addostostrategy.matrix([ubuntu-latest, windows-latest, macos-latest]) and switchruns-onto${{ matrix.os }}.fail-fast: falseand thenode-versionlist are unchanged.coverage-node-${{ matrix.os }}-${{ matrix.node-version }}) so the 3 OS × 10 Node matrix legs do not collide on a shared artifact name —actions/upload-artifactv4+ rejects duplicate artifact names with a 409 conflict. Thecoveragejob is untouched: it still collects everything matchingcoverage-node-*and thecoverage-node-*prefix is unchanged.lintandcoveragejobs remain onubuntu-latest.Verification
windows-latestleg):npm install,npm test,npm run lintall green — 273 passing, 0 failing. No test-file changes were needed; the suite is already platform-agnostic (no path/sep/process.platformusage; the only timing-sensitive assertion intest/text.jspasses on Windows).ciandCodeQLworkflow runs for this PR are pending maintainer approval (first-time contributor workflow). Only the local Windows baseline (Node 24: 273 passing, lint green) has been verified so far; the matrix will run once the maintainers approve the runs.