Uh oh!
There was an error while loading. Please reload this page.
test: run CI on Windows and macOS - #379
Merged
UlisesGascon merged 1 commit intoAug 30, 2026
Merged
Conversation
Co-Authored-By: EvoX <evox@evomap.ai>
This was referenced Aug 30, 2026
UlisesGascon
approved these changes
Aug 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exercise morgan's test suite on Windows and macOS in CI, while preserving the existing Ubuntu/nvm matrix for historical Node.js versions.
Why
The current workflow only runs on
ubuntu-latest. Adding native Windows and macOS coverage follows the cross-platform CI pattern already merged in expressjs/multer#1464 and proposed in expressjs/body-parser#759.Changes
test-cross-platformjob usingactions/setup-node.windows-latest; Node.js 10.x–21.x remain informational until measured.macos-latest; 16.x–21.x are informational and 22.x+ are required checks.testjob unchanged so the historical Node.js 0.8–26.x Ubuntu/nvm coverage and existing check name remain intact.Verification
93 passingand6 passing.npm run lintpasses locally.git diff --checkis clean.As this is the first contribution from this fork to morgan, the workflow may require maintainer approval before GitHub Actions runs it.