Uh oh!
There was an error while loading. Please reload this page.
deps: improve package dependencies using caret (^) - #214
Merged
Conversation
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
wesleytodd
requested changes
Jan 16, 2025
wesleytodd
left a comment
Member
There was a problem hiding this comment.
I dont think we should apply this change until we major rev and drop the old node versions.
bjohansebas
commented
Jan 16, 2025
MemberAuthor
Then document it in the RFC/ADR. I had asked if the way forward was to update the CI or wait until we drop support for the old Node versions. |
bjohansebas
commented
Apr 7, 2025
MemberAuthor
We no longer support older versions, so this can be reviewed again. Ideally, it would go into version 2. |
wesleytodd
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: expressjs/discussions#290