Uh oh!
There was an error while loading. Please reload this page.
Add policy on using caret (^) or tilde (~) with dependencies - #290
Conversation
bb4078a to
f8b639bCompareSigned-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com>
f8b639b to
778a16fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
blakeembrey
left a comment
There was a problem hiding this comment.
TL;DR I think we should try to be high trust and good examples of OSS by treating all dependencies the same.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wesleytodd
left a comment
There was a problem hiding this comment.
If @UlisesGascon is alright with the suggestions to use ^ for all, I tried to make change suggestions to everywhere I noticed where it was referenced. Personally I think the conservative approach used in earlier days is not necessary anymore and so am in favor of using it for all deps.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Worth mentioning that the caret ( |
ljharb
commented
Oct 27, 2024
@UlisesGascon it's not supported on the npm that comes with node 0.8, but if you use either way, i think it can be fine if you need a newer node to install it as long as it works in old node (albeit, not ideal) |
bjohansebas
commented
Oct 27, 2024
So we need to prepare the CI for the packages that still support node.js@0.8 before making any changes to the dependencies |
ljharb
commented
Oct 27, 2024
Yes, for any package that isn't already declaring engines, the first step should be testing (manual or automated) to determine on which versions it's already working - because those are the engines that it's non-breaking to declare. |
bjohansebas
commented
Nov 1, 2024
@expressjs/express-tc, the way forward is to update the CI, or do we prefer to do this in a major version when support for Node.js 0.8 is removed? |
I think the suggestions are mostly agreed upon, @UlisesGascon if you want to make these I can change my review to approved and we can merge this right? (or if you want I can merge them and do it myself, just didn't want to step on your toes) The rest of the questions/comments dont seem applicable now right? |
wesleytodd
commented
Jan 16, 2025
Ref: expressjs/compression#214 (comment) I don't think we should make the CI more complicated by applying this change to packages we have not rev'd to drop node versions. I think it is better to do nothing to those until we have another reason to major rev them. |
Uh oh!
There was an error while loading. Please reload this page.
jonchurch
commented
Feb 3, 2025
Im in favor of caret being the default for all deps, external or not. AKA I want to accept the suggestions to change the proposal to state that. |
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Co-authored-by: Wes Todd <wes@wesleytodd.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Wes Todd <wes@wesleytodd.com>

Policy on using caret (
^) or tilde (~) with dependencies^) or tilde (~) for dependencies that we maintain while avoiding its use for third-party dependencies.Context
^) with our own dependencies #279