Skip to content

docs: Add ADR template - #291

Merged
UlisesGascon merged 1 commit into
masterfrom
adr-template
Oct 28, 2024
Merged

docs: Add ADR template#291
UlisesGascon merged 1 commit into
masterfrom
adr-template

Conversation

@UlisesGascon

@UlisesGasconUlisesGascon commented Oct 22, 2024

Copy link
Copy Markdown
Member

closes#285

Note: this template was used in #290 and #289

Signed-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com>
@UlisesGascon
UlisesGascon requested a review from a teamOctober 22, 2024 19:49
@UlisesGasconUlisesGascon self-assigned this Oct 22, 2024

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjohansebasbjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it could also be added as a PR template.

@carpasse

Copy link
Copy Markdown

I would stick to the original template

Just because we can easily leverage the ADR generation using one of the available cli tools available on npm

@UlisesGascon

Copy link
Copy Markdown
MemberAuthor

As agreed on the last TC meeting I am merging the PR. @bjohansebas can you create the PR template?

@UlisesGascon
UlisesGascon merged commit 91704b5 into masterOct 28, 2024
@UlisesGasconUlisesGascon changed the title Add ADR templatedocs: Add ADR templateOct 28, 2024
@UlisesGascon
UlisesGascon deleted the adr-template branch October 28, 2024 20:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-thinking the discussion process

5 participants

@UlisesGascon@carpasse@blakeembrey@mertcanaltin@bjohansebas