Skip to content

✨ ADR: action pinning - #366

Merged
ctcpip merged 2 commits into
masterfrom
pin
May 12, 2025
Merged

✨ ADR: action pinning#366
ctcpip merged 2 commits into
masterfrom
pin

Conversation

@ctcpip

@ctcpipctcpip commented Apr 30, 2025

Copy link
Copy Markdown
Member

No description provided.

@ctcpip
ctcpip requested a review from a teamApril 30, 2025 16:06
@ctcpipctcpip added top priority Issues which the TC deem our current highest priorities for the project tc agenda labels Apr 30, 2025
@Phillip9587

Phillip9587 commented Apr 30, 2025

Copy link
Copy Markdown
Member

Should we note that if a repository opts to pin actions by commit SHA, it's recommended to set up Dependabot (or a similar tool) to regularly update these SHAs?

wesleytodd
wesleytodd approved these changes Apr 30, 2025
View reviewed changes

@wesleytoddwesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

1396308b-0814-47bd-b8fc-6b3965d31295

🤣 We moving to a content addressable sha for the ADR numbers? I approve!

@ctcpip

ctcpip commented Apr 30, 2025

Copy link
Copy Markdown
MemberAuthor

LGTM!

1396308b-0814-47bd-b8fc-6b3965d31295

🤣 We moving to a content addressable sha for the ADR numbers? I approve!

you put #306 on the perf one, so I was like... 🤷

@wesleytodd

wesleytodd commented Apr 30, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Ha, that was the number from the PR. Dont get me wrong, I like the creativity, we gotta keep people guessing.

EDIT: oops, looks like I forgot to update this one

EDIT 2: ok I went a bit overboard: #367

@github-actionsgithub-actionsBot mentioned this pull request Apr 30, 2025
Closed
UlisesGascon
UlisesGascon approved these changes May 1, 2025
View reviewed changes

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actionsgithub-actionsBot mentioned this pull request May 6, 2025
Closed
@ctcpip
ctcpip merged commit f487fde into masterMay 12, 2025
@ctcpip

ctcpip commented May 12, 2025

Copy link
Copy Markdown
MemberAuthor

TC reaffirmed today, we are merging

@ctcpip
ctcpip deleted the pin branch May 12, 2025 21:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleytoddwesleytoddwesleytodd approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
+3 more reviewers
@ljharbljharbljharb approved these changes
@Phillip9587Phillip9587Phillip9587 approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tc agendatop priorityIssues which the TC deem our current highest priorities for the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ctcpip@Phillip9587@wesleytodd@ljharb@UlisesGascon@bjohansebas