Skip to content

fix: ADR cleanup - #367

Merged
ctcpip merged 2 commits into
masterfrom
lts-adr-number
May 19, 2025
Merged

fix: ADR cleanup#367
ctcpip merged 2 commits into
masterfrom
lts-adr-number

Conversation

@wesleytodd

Copy link
Copy Markdown
Member

No description provided.

@wesleytodd
wesleytodd requested a review from ctcpipApril 30, 2025 22:27
@wesleytoddwesleytodd mentioned this pull request Apr 30, 2025
@ctcpip

Copy link
Copy Markdown
Member

hmmm... hate to say it but I think we need an ADR for numbering... UUID? monotonically increasing integer starting from 1? PR number? 🤔🤔🤔🤔🤔🤔🤔🤔🤔

@wesleytodd

Copy link
Copy Markdown
MemberAuthor

I was just kidding because of our exchange, but I really do think PR number is a reasonable way. No need to go look it up when merging (and forget, like I did). At least these numbers mean something.

@ctcpip

Copy link
Copy Markdown
Member

slight dispreference due to not knowing in advance what the PR number will be. (or guessing and risking race condition), meaning a follow-on commit will always be required

also not convinced we need numeric/symbolic identifiers at all, but I have little appetite to bikeshed this

@wesleytodd

Copy link
Copy Markdown
MemberAuthor

also not convinced we need numeric/symbolic identifiers at all, but I have little appetite to bikeshed this

Ok, you have me sold on this. I almost did this in the PR but realized that it meant the file names might become more important.

Honestly I just did this as a joke, we can even close it if we just want to let the lord of chaos reign.

@ctcpip
ctcpip merged commit 87956b1 into masterMay 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wesleytodd@ctcpip@UlisesGascon@bjohansebas