Uh oh!
There was an error while loading. Please reload this page.
Use packaged react-native in test-e2e-local script - #36703
Closed
fortmarek wants to merge 1 commit into
Closed
Conversation
analysis-bot
commented
Mar 29, 2023
Base commit: c1c22eb |
facebook-github-bot
commented
Mar 29, 2023
Contributor
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hoxyq
approved these changes
Mar 29, 2023
facebook-github-bot
commented
Mar 29, 2023
Contributor
@cipolleschi merged this pull request in 0328a8d. |
kelset pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: The current `test-e2e-local` script had two bugs: - On [this](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L219) line we were initializing a new RN project with the packed `react-native` created [here](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L211) - We were updating the local RN version after running `npm pack` [here](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L214). This meant that the version inside the packaged `react-native-xyz.tgz` was not updated since we ran `pack` before updating it. This was fine since the `init` command was using the local `react-native` repository instead of the packed version. ## Changelog: [INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: #36703 Test Plan: - Run `yarn test-e2e-local -t RNTestProject -p Android`. The command should succeed. I am not completely sure how to double check that we are using the packed version. Locally, I have a `fsmonitor--daemon.ipc` in my `react-native/.git` that can't be copied. The `.git` folder would be copied only when `cli.js init` was called with the whole repository – which is how I found out about the issue in the first place. Reviewed By: hoxyq Differential Revision: D44504599 Pulled By: cipolleschi fbshipit-source-id: e57e2858bab46d4f978eed3cbaf3e504138594b8 # Conflicts: # scripts/test-e2e-local.js
kelset pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: The current `test-e2e-local` script had two bugs: - On [this](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L219) line we were initializing a new RN project with the packed `react-native` created [here](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L211) - We were updating the local RN version after running `npm pack` [here](https://github.com/facebook/react-native/blob/c1c22ebacc4097ce56f19385161ebb23ee1624b3/scripts/test-e2e-local.js#L214). This meant that the version inside the packaged `react-native-xyz.tgz` was not updated since we ran `pack` before updating it. This was fine since the `init` command was using the local `react-native` repository instead of the packed version. ## Changelog: [INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: #36703 Test Plan: - Run `yarn test-e2e-local -t RNTestProject -p Android`. The command should succeed. I am not completely sure how to double check that we are using the packed version. Locally, I have a `fsmonitor--daemon.ipc` in my `react-native/.git` that can't be copied. The `.git` folder would be copied only when `cli.js init` was called with the whole repository – which is how I found out about the issue in the first place. Reviewed By: hoxyq Differential Revision: D44504599 Pulled By: cipolleschi fbshipit-source-id: e57e2858bab46d4f978eed3cbaf3e504138594b8
Merged
This was referenced Aug 10, 2023
This was referenced Sep 21, 2023
This was referenced Oct 11, 2023
Merged
This was referenced Nov 1, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
test-e2e-localscript had two bugs:react-nativecreated herenpm packhere. This meant that the version inside the packagedreact-native-xyz.tgzwas not updated since we ranpackbefore updating it. This was fine since theinitcommand was using the localreact-nativerepository instead of the packed version.Changelog:
[INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script
Test Plan
yarn test-e2e-local -t RNTestProject -p Android. The command should succeed.I am not completely sure how to double check that we are using the packed version. Locally, I have a
fsmonitor--daemon.ipcin myreact-native/.gitthat can't be copied. The.gitfolder would be copied only whencli.js initwas called with the whole repository – which is how I found out about the issue in the first place.