Skip to content

Fix test e2e script - #37081

Merged
kelset merged 1 commit into
react:0.70-stablefrom
fortmarek:fortmarek/fix-test-e2e-script
Apr 25, 2023
Merged

Fix test e2e script#37081
kelset merged 1 commit into
react:0.70-stablefrom
fortmarek:fortmarek/fix-test-e2e-script

Conversation

@fortmarek

Copy link
Copy Markdown
Contributor

Summary:

This PR fixes the same issues as this one for main did.

Changelog:

[INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script

Test Plan:

Run ./scripts/test-manual-e2e.sh for RNTestProject –> this script should succeed.

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Apr 25, 2023
@kelset

kelset commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

LGTM - let's port it back to 0.69 branch too (via directly cherry-pick once this is squashed&merged)

@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 5e983d5
Branch: main

@kelset
kelset merged commit 8c90612 into react:0.70-stableApr 25, 2023
kelset pushed a commit that referenced this pull request Apr 25, 2023
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a7,600,649-1,024,248
androidhermesarmeabi-v7a7,019,332-918,200
androidhermesx867,902,470-1,209,308
androidhermesx86_647,874,200-1,092,431
androidjscarm64-v8a9,482,299+293,355
androidjscarmeabi-v7a8,263,056-115,985
androidjscx869,422,252+175,079
androidjscx86_6410,013,414+507,740

Base commit: 5e983d5
Branch: main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: ShopifyPartner: ShopifyPartner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@fortmarek@kelset@analysis-bot@facebook-github-bot