✅ Improve E2E tests coverage for Admin page

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!

[ioanzicu]

E2E tests for Admin page:

✅ Admin tab table should be visible
✅ User Dialog should have all fields visible
✅ User Dialog should have all error fields visible
✅ Admin should fill out the Add User form, save then delete it

[tiangolo]

Thanks for the interest! It seems this PR was created without the permissions to let maintainers push to it, so I can't update the branch to trigger pre-commit and CI again, etc.

Could you enable that option please so that I can push to this branch?

[ioanzicu]

Sure, I have enabled the "Allow edits by maintainers".

[tiangolo]

This ended up covered in another PR, to keep consistency with other parts, test other cases, etc. But the problem is now solved. Thanks! 🍰

[ioanzicu]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

[alejsdev]

:( not fair. I wanted to have some contribution on my name, but it results my copy pasted code and I am left with a closed MR.

Hello @ioanzicu, thanks for the interest in contributing to the project. You can take a look at the other PR here: #2146

We didn't "copy-paste" your PR, our approach was just different and more aligned with the current suite of tests. Your PR focused on UI structure verification, used hard-coded test data, and combined scenarios such as create + delete into a single test. After reviewing, we realized it was better to add the first suite of tests for the missing features (admin + items) rather than rewrite your PR or ask for extensive changes. Our approach uses random test data for test isolation, separate tests per action, and includes more test scenarios. For future contributions, feel free to start a discussion first to align on the approach. Thanks again for the effort!