👷 Add `ty` to precommit by svlandeg · Pull Request #2227 · fastapi/full-stack-fastapi-template

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

svlandeg · 2026-03-10T11:08:05Z

Add ty to pyproject, lint.sh & precommit
Ensure that warnings are reported as errors
Added some type fixes to make ty happy
Includes a bug fix (I think) ? cf separate review comment 👇

svlandeg · 2026-03-10T14:06:58Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

…api-template into feat/ty

svlandeg

@alejsdev : by bumping to ty 0.0.25, we're able to have less ignore statements when combining mypy with ty, cf this edit. So I think that's nice! I also changed the settings to error on warning, as discussed with Sebastián - we'll do this for all our repos. So this should be in a good state to review/merge (again) now 🙏

tiangolo

Awesome, thank you! 🚀

tiangolo · 2026-04-03T11:45:16Z

 def downgrade():
 # ### commands auto generated by Alembic - please adjust! ###
- op.drop_constraint(None, 'item', type_='foreignkey')
+ op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')


I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other op.drop_constraint() calls have a name, and tests seem to pass, so we're probably good. ✔️

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

add ty to precommit
261669c

svlandeg added the internal Internal changes label Mar 10, 2026

fix syntax
3d0456e

svlandeg marked this pull request as draft March 10, 2026 11:09

svlandeg added 5 commits March 10, 2026 14:37

assert that configuration is not None
0922a66

convert Item/User to ItemPublic/UserPublic
61d8a05

ty ignore unnecessary ignore statements
8c1470c

add one type ignore
2b1a1e1

two more fixes
30c4abd

svlandeg commented Mar 10, 2026
View reviewed changes

try with download version 4
20a410f

svlandeg commented Mar 10, 2026
View reviewed changes

Comment thread.github/workflows/playwright.yml Outdated

svlandeg requested a review from alejsdev March 10, 2026 15:01

svlandeg marked this pull request as ready for review March 10, 2026 15:01

alejsdev approved these changes Mar 12, 2026
View reviewed changes

svlandeg commented Mar 17, 2026
View reviewed changes

Comment threadbackend/scripts/lint.sh Outdated

fix
a0a79db

svlandeg marked this pull request as draft March 26, 2026 22:21

svlandeg self-assigned this Mar 26, 2026

svlandegand others added 5 commits March 26, 2026 23:25

ensure that a ty warning creates an error
59ef24d

Merge branch 'master' into feat/ty
cbf8b85

🎨 Auto format and update with pre-commit
33d1cc5

Merge branch 'feat/ty' ofhttps://github.com/svlandeg/full-stack-fast…
946e9a0
…api-template into feat/ty

update to ty >= 0.0.25
1ea0613

svlandeg removed their assignment Mar 26, 2026

svlandeg marked this pull request as ready for review March 26, 2026 23:14

try reverting the download version change
aee0392

svlandeg marked this pull request as draft March 27, 2026 09:57

svlandeg self-assigned this Mar 27, 2026

cleanup
403f000

svlandeg marked this pull request as ready for review March 27, 2026 10:05

svlandeg removed their assignment Mar 27, 2026

svlandeg commented Mar 27, 2026
View reviewed changes

svlandeg requested a review from alejsdev March 27, 2026 10:07

tiangolo approved these changes Apr 3, 2026
View reviewed changes

tiangolo merged commit 2fdd62c into fastapi:masterApr 3, 2026
16 checks passed

svlandeg deleted the feat/ty branch April 3, 2026 11:55

BraidaFac pushed a commit to BraidaFac/insurance-broker-api that referenced this pull request Apr 27, 2026
👷 Addtyto precommit (fastapi#2227)
febeb9c
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

fangxu6 pushed a commit to fangxu6/full-stack-fastapi-template that referenced this pull request May 5, 2026
👷 Addtyto precommit (fastapi#2227)
19c2c4a
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Uh oh!

Uh oh!

Conversation

svlandeg commented Mar 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

svlandeg left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

svlandeg commented Mar 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

svlandeg left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

svlandeg commented Mar 10, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

svlandeg left a comment

Choose a reason for hiding this comment

Uh oh!

tiangolo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

svlandeg commented Mar 10, 2026•
edited
Loading

svlandeg commented Mar 10, 2026•
edited
Loading

svlandeg commented Mar 10, 2026•
edited
Loading

svlandeg commented Mar 10, 2026•
edited
Loading