Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 9k
👷 Add ty to precommit#2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
👷 Add ty to precommit
#2227
Changes from all commits
261669c3d0456e0922a6661d8a058c1470c2b1a1e130c4abd20a410fa0a79db59ef24dcbf8b8533d1cc5946e9a01ea0613aee0392403f000File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -4,5 +4,6 @@ set -e | ||
| set -x | ||
| mypy app | ||
| ty check app | ||
| ruff check app | ||
| ruff format app --check | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little confused about this one, as
drop_constraintrequires astrconstraint name. Not sure why it wasNonebefore and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused too, this is generated automatically, don't really know what it might be... but also, all the other
op.drop_constraint()calls have a name, and tests seem to pass, so we're probably good. ✔️