Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 20, 2026. It is now read-only.
deps: bump kernels pin to the diag_bending/diag_all corner cross-term fix - #72
Merged
Conversation
… fix Picks up fastfields-kernels#81 (1df9fd3), which corrects the doubled fx1*fy0 / dropped fx0*fy1 corner term in the boundary-corrected diagonal of diag_bending (field 2d/3d, flow 2d/3d) and diag_all (flow 2d/3d). Also carries kernels#79 (93a954b), the restrict.h -> batch.h include for index2sub, which the previous pin (be7be08) predated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Submodule staleness (non-blocking -- fastfields-lib#15)
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
kernelsgitlink frombe7be08to1df9fd3(currentfastfields-kernelsmain). Gitlink-only —git diff-treebetweenmainand this branch reports exactly one modified path,kernels.What it picks up
1df9fd3fx1*fy0/ droppedfx0*fy1corner term in the boundary-corrected diagonal ofdiag_bending(field 2d/3d, flow 2d/3d) anddiag_all(flow 2d/3d). Corruptedfield_diag/flow_diagat boundary voxels under sign-flipping bounds with bending active, and any Jacobi preconditioner built from it.93a954brestrict.hnow includesbatch.hforindex2sub. The old pin predated it, so this tree could not be compiled by g++ at all.be7be08is an ancestor of1df9fd3, so this is a fast-forward of the pin with no history surprises.Pin hygiene
1df9fd3is the squash-merge commit that actually exists onfastfields-kernelsmain, not the pre-merge branch head (81cd9a4, which ceased to exist as a reachable ref when #81 was squashed). Verified it resolves before opening this PR.Verification
Full CPU suite against this exact kernels commit through the dev-tree symlink chain (
cpu-lib/impl -> cpu-impl -> kernels@1df9fd3),make -j4 test CXX=clang++— 13/13 suites pass, 0 failures:The regression test that actually fails without kernels#81 lands separately on
fastfields-cpu-lib, once itsimplpin reaches this commit.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code