Skip to content

chore(ci): wrapper repos can't install private fastfields-dlpack in CI #13

Description

@balbasty

The wrapper repos (fastfields-numpy/-torch/-cupy/fastfields) install the compiled binding in test.yaml via:

pip install "fastfields-dlpack @ git+https://github.com/fastfields/fastfields-bind-py@main"

This fails on two counts:

  1. Private repo, no creds:fatal: could not read Username for 'https://github.com' — the runner has no credentials for the private bind-py.
  2. No submodules: even with creds, pip's git clone does not fetch submodules, so the dlpack source build (which needs _fastfields_lib → lib → cpu/cuda → impl → kernels) can't build.

So the wrapper repos' pytest matrix is red for a reason independent of everything else (their ruff lint is green and pinned). Deferred per maintainer decision — it doesn't block the C++/bind-py stack.

Options, best last:

  • (a) credentialed install (CI_SUBMODULE_TOKEN via git insteadOf) plus a submodule-aware build — more CI YAML, still a source build per job.
  • (b) checkout bind-py with submodules: recursive and pip install ./path from a local checkout.
  • (c, recommended) install fastfields-dlpack from the wheel index (fastfields.github.io/whl) once a dlpack wheel is published there — no per-job source build, matches the intended distribution model.

Recommend (c) once the release workflow publishes a dlpack wheel; until then the wrapper pytest legs stay red-by-design.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions