Skip to content

PROPOSAL (do not merge): what core/ means, and a naming scheme#148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balbasty wants to merge 6 commits into from
Closed

PROPOSAL (do not merge): what core/ means, and a naming scheme #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
616d67a
docs: propose what core/ means, and a naming scheme, with measured costs
claude Aug 20, 2026
b67b52e
PROTOTYPE (evidence, not a request to merge): apply the core/ move
claude Aug 20, 2026
978b1a8
Revert "PROTOTYPE (evidence, not a request to merge): apply the core/…
claude Aug 20, 2026
9e05a3e
Merge remote-tracking branch 'origin/main' into design/core-split-pro…
claude Aug 20, 2026
5e39995
docs: record the live rebase onto #146, and correct the vox site count
claude Aug 20, 2026
dd99b5c
PROTOTYPE (evidence, not a request to merge): re-apply the core/ move…
claude Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
820 changes: 820 additions & 0 deletions docs/proposals/core-and-naming.md
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion include/fastfields/api/cpu/pushpull_dispatch.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
#include <fastfields/core/dispatch.h>
#include <fastfields/core/dlpack.h>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/utils.h>
#include <fastfields/impl/cpu/pushpull.h>

FF_NAMESPACE_BEGIN(FF_NS)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/api/cuda/pushpull_dispatch.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
#include <fastfields/core/dispatch.h>
#include <fastfields/core/dlpack.h>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/utils.h>
#include <fastfields/impl/cuda/pushpull.h>

FF_NAMESPACE_BEGIN(FF_NS)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/atomic.h → include/fastfields/core/atomic.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@

#ifndef FF_ATOMIC
#define FF_ATOMIC
#include <fastfields/core/cuda_switch.h>
#include "cuda_switch.h"

/***********************************************************************
* CPU
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/batch.h → include/fastfields/core/batch.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@
*/
#ifndef FF_BATCH
#define FF_BATCH
#include <fastfields/core/cuda_switch.h>
#include "cuda_switch.h"
#include "utils.h"

FF_NAMESPACE_BEGIN(FF_NS)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/bounds.h → include/fastfields/core/bounds.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
#ifndef FF_BOUNDS
#define FF_BOUNDS
#include <fastfields/core/cuda_switch.h>
#include "cuda_switch.h"
#include "atomic.h"
#include "utils.h"
#include "meta.h"
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/meta.h → include/fastfields/core/meta.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
#ifndef FF_META
#define FF_META
#include <fastfields/core/defines.h>
#include "defines.h"

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(meta)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/parallel.h → include/fastfields/core/parallel.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
#ifndef FF_PARALLEL_H
#define FF_PARALLEL_H
#include <cstdint>
#include <fastfields/core/defines.h>
#include "defines.h"
#include "parallel_impl.h"

/* The minimum number of elements a `parallel_for` must cover before it is
Expand Down
2 changes: 1 addition & 1 deletion ...e/fastfields/impl/kernels/parallel_impl.h → include/fastfields/core/parallel_impl.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
*/
#ifndef FF_PARALLEL_IMPL_H
#define FF_PARALLEL_IMPL_H
#include <fastfields/core/defines.h>
#include "defines.h"
#include <queue>
#include <string>

Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/spline.h → include/fastfields/core/spline.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,7 @@

#ifndef FF_SPLINE
#define FF_SPLINE
#include <fastfields/core/cuda_switch.h>
#include "cuda_switch.h"
#include "meta.h"

FF_NAMESPACE_BEGIN(FF_NS)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/threadpool.h → include/fastfields/core/threadpool.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@
#include <condition_variable>
#include <functional>
#include <memory>
#include <fastfields/core/defines.h>
#include "defines.h"

FF_NAMESPACE_BEGIN(FF_NS)

Expand Down
2 changes: 1 addition & 1 deletion ...de/fastfields/impl/kernels/threadpool.inl → include/fastfields/core/threadpool.inl
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
#include <memory>
#include <string>
#include <thread>
#include <fastfields/core/defines.h>
#include "defines.h"

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(internal)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/utils.h → include/fastfields/core/utils.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
#ifndef FF_UTILS
#define FF_UTILS
#include <limits>
#include <fastfields/core/cuda_switch.h>
#include "cuda_switch.h"

#ifndef __CUDACC__
# include <cmath>
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cpu/distance_euclidean.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,9 @@
#define FF_CPU_DISTANCE_EUCLIDEAN
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>
#include <fastfields/core/utils.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cpu/distance_l1.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,9 @@
#define FF_CPU_DISTANCE_L1
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>
#include <fastfields/core/utils.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cpu/distance_mesh.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,8 @@
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/distance/mesh_utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cpu/distance_spline.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,8 @@
#define FF_CPU_DISTANCE_SPLINE
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cpu/posdef.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,8 @@
#define FF_POSDEF_CPU
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/posdef.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cpu/pushpull.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,9 @@
#define FF_PUSHPULL_CPU
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/pushpull.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>
#include <fastfields/core/utils.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
8 changes: 4 additions & 4 deletions include/fastfields/impl/cpu/reg_field.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,10 +2,10 @@
#define FF_REGULARISERS_FIELD_CPU
#include <stdexcept>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>
#include <fastfields/impl/kernels/regularisers/field.h>
#include <fastfields/impl/kernels/posdef.h>

Expand Down
8 changes: 4 additions & 4 deletions include/fastfields/impl/cpu/reg_flow.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,10 +2,10 @@
#define FF_REGULARISERS_FLOW_CPU
#include <stdexcept>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>
#include <fastfields/impl/kernels/regularisers/flow.h>
#include <fastfields/impl/kernels/posdef.h>

Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cpu/resize.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,8 @@
#define FF_RESIZE_LOOP
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/resize.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cpu/restrict.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,8 @@
#define FF_RESTRICT_LOOP
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/restrict.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cpu/solve_field.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,9 @@
#define FF_SOLVE_FIELD_CPU
#include <vector>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cpu/splinc.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,9 @@
#define FF_SPLINC_LOOP
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/splinc.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/parallel.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/parallel.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/cuda/distance_euclidean.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/batch.h>
#include "utils.h"
#include <exception>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/cuda/distance_l1.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/batch.h>
#include "utils.h"
#include <exception>
#include <cstdint>
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cuda/distance_mesh.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/utils.h>
#include "utils.h"
#include <cstdint>
#include <memory> // std::unique_ptr
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cuda/distance_spline.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,8 @@
#include <stdexcept>
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/distance.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/core/utils.h>

using namespace std;
FF_NAMESPACE_BEGIN(FF_NS)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/cuda/posdef.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/posdef.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/batch.h>
#include "utils.h"
#include <cstdint>
#include <stdexcept>
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cuda/pushpull.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/spline.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/spline.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/batch.h>
#include <fastfields/impl/kernels/pushpull.h>
#include "utils.h" // allocDevice / copyToDevice / freeDevice / GET_BLOCKS
#include <cstdint> // std::intptr_t
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cuda/reg_field.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/impl/kernels/regularisers/field.h>
#include <fastfields/impl/kernels/posdef.h>
#include "utils.h" // allocDevice / copyToDevice / freeDevice / GET_BLOCKS
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cuda/reg_flow.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/utils.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/utils.h>
#include <fastfields/core/batch.h>
#include <fastfields/impl/kernels/regularisers/flow.h>
#include <fastfields/impl/kernels/posdef.h>
#include "utils.h" // allocDevice / copyToDevice / freeDevice / GET_BLOCKS
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cuda/resize.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,9 +5,9 @@
*/

#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/spline.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/spline.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/batch.h>
#include <fastfields/impl/kernels/resize.h>
#include "utils.h"
#include <cstdint>
Expand Down
6 changes: 3 additions & 3 deletions include/fastfields/impl/cuda/restrict.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,9 +6,9 @@
*/

#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/spline.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/spline.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/batch.h>
#include <fastfields/impl/kernels/restrict.h>
#include "utils.h"
#include <cstdint>
Expand Down
4 changes: 2 additions & 2 deletions include/fastfields/impl/cuda/splinc.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
#pragma once
#include <fastfields/core/cuda_switch.h>
#include <fastfields/impl/kernels/splinc.h>
#include <fastfields/impl/kernels/bounds.h>
#include <fastfields/impl/kernels/batch.h>
#include <fastfields/core/bounds.h>
#include <fastfields/core/batch.h>
#include "utils.h"
#include <cstdint>
#include <stdexcept>
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/distance/euclidean.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
#ifndef FF_DISTANCE_E
#define FF_DISTANCE_E
#include <fastfields/core/cuda_switch.h>
#include "../utils.h"
#include <fastfields/core/utils.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
2 changes: 1 addition & 1 deletion include/fastfields/impl/kernels/distance/l1.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
#ifndef FF_DISTANCE_L1
#define FF_DISTANCE_L1
#include <fastfields/core/cuda_switch.h>
#include "../utils.h"
#include <fastfields/core/utils.h>

FF_NAMESPACE_BEGIN(FF_NS)
FF_NAMESPACE_BEGIN(FF_DEVICE)
Expand Down
Loading
Loading