Uh oh!
There was an error while loading. Please reload this page.
DO NOT MERGE - scratch probe proving the two lint behaviours from #156 - #157
Closed
balbasty wants to merge 1 commit into
Closed
DO NOT MERGE - scratch probe proving the two lint behaviours from #156#157balbasty wants to merge 1 commit into
balbasty wants to merge 1 commit into
Conversation
Not for merge. One file, deliberately carrying two defects at once: a quoted public include (must turn lint (source conventions) RED) and deliberate mis-formatting (must make lint (clang-format, changed lines) print a diff and stay GREEN). Path matches no filter, so only the lint jobs run -- no test-cpu, no build-cuda.
balbasty
commented
Aug 20, 2026
CollaboratorAuthor
Evidence collected — both behaviours confirmed against real Actions. Closing; branch deleted. Recorded on #156.
Three things worth recording beyond the headline:
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway. Not for review, not for merge — will be closed and the branch
deleted as soon as it has produced its evidence.
Exists only to exercise #156's two new lint behaviours against real GitHub
Actions, since #89 happened precisely because nobody ever ran the failure
branch. Based on #156's branch (not
main) and adds exactly one file, at apath matching no entry in the
changesfilter — so only the lint jobs run:no
test-cpu, nobuild-cuda.tests/format_probe.cppcarries two deliberate defects at once:#include "fastfields/core/defines.h"— quoted public includelint (source conventions)RED, namingnormalise-include-delimitersand the file:linelint (clang-format, changed lines)GREEN, having printed the diff, a::notice::and a step-summary blockThe second is the interesting one: green while reporting findings is the whole
point of #156, and the exact case that used to be red-and-silent.
Generated by Claude Code