Skip to content

DO NOT MERGE - scratch probe proving the two lint behaviours from #156 - #157

Closed
balbasty wants to merge 1 commit into
ci/clang-format-informational-and-convention-gatesfrom
ci/scratch-prove-lints
Closed

DO NOT MERGE - scratch probe proving the two lint behaviours from #156#157
balbasty wants to merge 1 commit into
ci/clang-format-informational-and-convention-gatesfrom
ci/scratch-prove-lints

Conversation

@balbasty

Copy link
Copy Markdown
Collaborator

Throwaway. Not for review, not for merge — will be closed and the branch
deleted as soon as it has produced its evidence.

Exists only to exercise #156's two new lint behaviours against real GitHub
Actions, since #89 happened precisely because nobody ever ran the failure
branch. Based on #156's branch (not main) and adds exactly one file, at a
path matching no entry in the changes filter — so only the lint jobs run:
no test-cpu, no build-cuda.

tests/format_probe.cpp carries two deliberate defects at once:

defectexpected job outcome
#include "fastfields/core/defines.h" — quoted public includelint (source conventions)RED, naming normalise-include-delimiters and the file:line
deliberate mis-formattinglint (clang-format, changed lines)GREEN, having printed the diff, a ::notice:: and a step-summary block

The second is the interesting one: green while reporting findings is the whole
point of #156, and the exact case that used to be red-and-silent.


Generated by Claude Code

Not for merge. One file, deliberately carrying two defects at once:
a quoted public include (must turn lint (source conventions) RED) and
deliberate mis-formatting (must make lint (clang-format, changed lines)
print a diff and stay GREEN). Path matches no filter, so only the lint
jobs run -- no test-cpu, no build-cuda.
@balbastyClaude

Copy link
Copy Markdown
CollaboratorAuthor

Evidence collected — both behaviours confirmed against real Actions. Closing; branch deleted. Recorded on #156.

Run 32417649104:

jobconclusion
lint (source conventions)failuretests/format_probe.cpp:7: fastfields/core/defines.h -- public header, must use <>, exit 1
lint (clang-format, changed lines)successprinted the full diff and a ##[notice] annotation, exit 0
all test-cpu / build-cuda / test-hub legsskippedpath matched no filter, as intended

Three things worth recording beyond the headline:

  • The clang-format job was green while reporting. That is the exact case that used to be red-and-silent under CI: the clang-format job can never print its findings (set -e kills it before the report) #89.
  • The if: !cancelled() guard works: after normalise-include-delimiters failed, normalise-header-guards and rename-macros both still ran and reported clean. A change tripping two conventions hears about both in one run.
  • lint (source conventions) finished in ~3 seconds wall clock (21:06:14 → 21:06:17) with no apt and no setup-python, using the runner image's own interpreter.

Generated by Claude Code

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@balbasty