Uh oh!
There was an error while loading. Please reload this page.
Claude/jitfields fastfields migration v5r416 - #2
Merged
Conversation
…GRATION Public ff:: resample/restriction/spline_coeff dispatching on device to the cpu/cuda libs (cuda guarded by FF_WITH_CUDA). Makefile: add the three modules to MODULES (CPU-only build links). MIGRATION.md: refresh status matrix, record the threadpool multi-module link fix and the module bug fixes, note the cuda host-launcher gap and the resample/restriction/spline_coeff naming.
Surfaced while building the nanobind bindings against fastfields-lib: - distance.cpp/posdef.cpp used 'using namespace FF;' then defined the dispatchers at global scope, so symbols were emitted as ::dt_euclidean / ::sym_matvec instead of ff:: as the headers declare -> ff:: callers got undefined references. Wrap the bodies in FF_NAMESPACE_BEGIN(FF)/END like resize/restrict/splinc. - distance.h defined bound_t/spline_t without the FF_LIB_BOUND_SPLINE_T guard the other headers use -> redefinition when co-included. Add the guard. - Makefile RPATH used $$ORIGIN unquoted, so the recipe shell expanded $ORIGIN to empty (runpath became /../lib). Single-quote it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
pushpull: pull/push/count/grad exposed through cpu-lib/cuda-lib/lib (dim x spline x bound x dtype dispatch); extrapolate de-templated to a runtime arg to keep -O2 build times sane. regularisers: flow_matvec/flow_diag and field_matvec/field_diag for absolute/membrane/bending. Many impl+kernel bug fixes (namespace/lookup/typos, a C++11 function-pointer-NTTP blocker, negative array-bound params under dynamic C, missing includes). CPU tests: pushpull 104, reg_field 272, reg_flow 282; full 8-module lib links and distance/posdef/ resize/restrict/splinc regressions stay green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.