Uh oh!
There was an error while loading. Please reload this page.
pushpull: drop FF_CUDA_NO_PUSHPULL now that pushpull is in cuda-lib's MODULES - #45
Merged
Merged
Conversation
…cuda-lib pushpull joined fastfields-cuda-lib's MODULES in fastfields-cuda-lib#30 (bound::type::Dynamic + a new spline::type::Dynamic keep its compile cost bounded the same way reg_field/reg_flow's was), so the CUDA path no longer needs to be compiled out here to keep the FF_WITH_CUDA link resolved. - Makefile: USE_CUDA=1 no longer adds -DFF_CUDA_NO_PUSHPULL. - pushpull.cpp: #if defined(FF_WITH_CUDA) && !defined(FF_CUDA_NO_PUSHPULL) -> plain #ifdef FF_WITH_CUDA, matching every other module (reg_field.cpp et al.) that never needed the extra guard. - CLAUDE.md / MIGRATION.md: drop the stale FF_CUDA_NO_PUSHPULL mentions and the "~40 min to compile" note now that the actual measured numbers (see fastfields-cuda-lib#30) are far lower under the default policy. Part of fastfields-cuda-lib#30. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Part of fastfields-cuda-lib#30. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
…ization, param reorder, macro fold) Part of fastfields-cuda-lib#30. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
…c stack merge) cpu-lib#48 merged as 3cf1004, cuda-lib#31 merged as 51cdc27 (merge commit SHAs differ from the PR branch heads this was previously pinned to). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workstream: claude-jitfields-to-fastfields
Part of fastfields/fastfields-cuda-lib#30.
pushpulljoinedfastfields-cuda-lib'sMODULESin fastfields/fastfields-cuda-lib#31 (bound::type::Dynamic+ a newspline::type::Dynamickeep its compile cost bounded the same wayreg_field/reg_flow's was), so the CUDA path in this hub no longer needs to be compiled out to keep theFF_WITH_CUDAlink resolved.Makefile:USE_CUDA=1no longer adds-DFF_CUDA_NO_PUSHPULL.pushpull.cpp:#if defined(FF_WITH_CUDA) && !defined(FF_CUDA_NO_PUSHPULL)→ plain#ifdef FF_WITH_CUDA, matching every other module (reg_field.cppet al.) that never needed the extra guard.CLAUDE.md/MIGRATION.md: drop the staleFF_CUDA_NO_PUSHPULLmentions and the "~40 min to compile" note now that the actual measured numbers (pushpull: wire into MODULES via bound::type::Dynamic + new spline::type::Dynamic fastfields-cuda-lib#31) are far lower under the default policy.cpu/cudasubmodule pins bumped to pushpull: route bound/spline dispatch through static/Dynamic selector macros + add SPLINEFLAGS fastfields-cpu-lib#48 and pushpull: wire into MODULES via bound::type::Dynamic + new spline::type::Dynamic fastfields-cuda-lib#31.Depends on fastfields/fastfields-cpu-lib#48 and fastfields/fastfields-cuda-lib#31.
Test plan
make all CXX=clang++(CPU-only):libfastfields-cpu.so+libfastfields.sobuild cleanly,pushpullincluded, no errors.make all CXX=clang++ USE_CUDA=1:libfastfields-cuda.so+libfastfields.sobuild and link cleanly against both backends,pushpull'sFF_CUDA::symbols resolve with the guard removed, no errors. Compile+link only (no GPU in CI, as with every other module here).🤖 Generated with Claude Code
Generated by Claude Code