Skip to content

fix: make libfastfields.so link depend on cpu/cuda sub-libraries#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balbasty merged 1 commit into from
Aug 5, 2026
Merged

fix: make libfastfields.so link depend on cpu/cuda sub-libraries #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -183,10 +183,15 @@ $(BUILDDIR)/lib/libfastfields-cpu.$(SOSUF): $(BUILDDIR)
$(BUILDDIR)/lib/libfastfields-cuda.$(SOSUF): $(BUILDDIR)
$(MAKE) -C cuda install

$(BUILDDIR)/libfastfields.$(SOSUF): $(OBJECTS)
# Real prerequisites (not just siblings under the `lib:` recipe-less target)
# so `make -j` can't run this link step before the cpu/cuda sub-libraries it
# links against actually exist -- see #56. ($^ would pull the .so
# prerequisites into the link line too, so the recipe lists $(OBJECTS)
# explicitly instead.)
$(BUILDDIR)/libfastfields.$(SOSUF): $(OBJECTS) $(BUILDDIR)/lib/libfastfields-cpu.$(SOSUF) $(CUDA_DEP)
$(CXX) $(CXXFLAGS) -shared $(PICFLAG) $(SONAME_FLAG) $(RPATH) \
-L$(BUILDDIR)/lib -lfastfields-cpu $(CUDA_LDFLAGS) \
-o $@ $^
-o $@ $(OBJECTS)

########################################################################
# Objects
Expand Down
Loading