Uh oh!
There was an error while loading. Please reload this page.
chore: bump cpu/cuda pins to the RLS/JRLS kernel fixes and test coverage - #68
Merged
Merged
Conversation
cuda: b8e5e9c -> 6ae52bd (fastfields-cuda-lib#46) Completes the propagation of fastfields-cuda-impl#41, which moved cuda-impl's kernels pin to main after it had fallen nine commits behind. The CUDA path was missing two field/flow regulariser correctness fixes the CPU path already had: fastfields-kernels#64 make_kernel_bending_rls rescaled its whole coefficient table by 0.25, running the membrane penalty at half strength whenever the bending-order RLS/JRLS kernel is built. Upstream measured max |matvec_bending - matvec_bending_rls(w=1)| of 1.8e+00 (2D) / 1.7e+00 (3D) before, ~1e-14 after. fastfields-kernels#52 guards the weight-map neighbour reads in the RLS/JRLS kernels (out-of-bounds read). With this the CPU and CUDA paths finally sit on the same kernels commit (b09b284). cpu: bf57a02 -> 13af367 (fastfields-cpu-lib#83) Adds ground-truth coverage for the wc == 1 (JRLS broadcast) direction, which had none: the #65 predicate bug mis-routed both weight-map layouts, but only wc == nc was regression-tested. Also unswaps the RLS/JRLS labels in cpu-lib's public header and test comments. No source changes here; both sub-libraries' own CI (including cuda-lib's 51-minute nvcc build) is green on the pinned commits. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final link in the propagation chain from an independent re-review of the
fastfields-cpu-lib#65RLS/JRLS fix chain.cuda:b8e5e9c→6ae52bd(fastfields-cuda-lib#46)Completes propagation of
fastfields-cuda-impl#41, which moved cuda-impl'skernelspin to main after it had fallen nine commits behind. The CUDA path was missing two field/flow regulariser correctness fixes the CPU path already had:fastfields-kernels#64make_kernel_bending_rlsrescaled its whole coefficient table by0.25, running the membrane penalty at half strength whenever the bending-order RLS/JRLS kernel is built (bending != 0alongsidemembrane != 0). Upstream measuredmax |matvec_bending - matvec_bending_rls(w=1)|of 1.8e+00 (2D) / 1.7e+00 (3D) before, ~1e-14 after. The existing self-adjointness tests are blind to it — a term at the wrong strength stays perfectly symmetric.fastfields-kernels#52With this, the CPU and CUDA paths finally sit on the same kernels commit (
b09b284).cpu:bf57a02→13af367(fastfields-cpu-lib#83)Adds ground-truth coverage for the
wc == 1(JRLS broadcast) direction, which previously had none. The#65predicate bug mis-routed both weight-map layouts, but onlywc == ncwas regression-tested; thewc == 1case went to the per-channel_rlskernels and read out of bounds past the single weight channel, yet every test exercising it stayed green because each compared the operator against itself.Measured on that branch, reverting only
#73's predicate flip: 18284 checks / 6141 failures, of which 3056 come from the newly-covered direction (previously 0). Clean run: 18284 / 0.Also unswaps the RLS/JRLS labels in cpu-lib's public header and test comments.
Verification
No source changes here. Both sub-libraries' own CI is green on the exact pinned commits, including
fastfields-cuda-lib#46's 51-minute nvcc build.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code