Uh oh!
There was an error while loading. Please reload this page.
deps: bump cpu/cuda pins so the whole tree agrees on one kernels commit - #77
Merged
Conversation
Moves cpu dbd3274 -> 1fb2b37 and cuda 6ae52bd -> 2b2ad55, the current mains of fastfields-cpu-lib and fastfields-cuda-lib. This is the top of a bottom-up cascade that closes a live pin skew. Before it, the two backends resolved to different kernels commits: CPU path : lib -> cpu-lib -> cpu-impl -> kernels be7be08 CUDA path: lib -> cuda-lib -> cuda-impl -> kernels b09b284 (three behind) The CUDA side was missing kernels#74 (heap over-read from the past-the-end FaceIterator, a memory-safety fix), #76 (make the host BVH/normal builders visible to nvcc's host pass -- a CUDA-specific fix the CUDA path lacked) and #78 (drop the pointless virtual destructors). After this commit every path resolves to kernels 1df9fd3: lib -> cpu-lib 1fb2b37 -> cpu-impl 5e2c78e -> kernels 1df9fd3 lib -> cuda-lib 2b2ad55 -> cuda-impl 83fa026 -> kernels 1df9fd3 The cascade also carries the diag_bending/diag_all corner cross-term correctness fix (kernels#81) to both backends, its regression test (cpu-lib#89), the reg_flow Lame dispatch routing (cpu-lib#87) and the cuda-impl include guards (cuda-impl#48). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top of a bottom-up cascade that closes a live submodule pin skew. Gitlink-only —
git diff-treereports exactly two modified paths,cpuandcuda.cpu:dbd3274→1fb2b37(currentfastfields-cpu-libmain)cuda:6ae52bd→2b2ad55(currentfastfields-cuda-libmain)The skew
Traced by walking the actual gitlinks on
main, not the submodule branch labels:The two backends genuinely resolved to different kernels commits, CUDA three behind:
32951daFaceIterator— a memory-safety fix3e38c85be7be08Node/BoundingSphereTwo details worth recording, both found by tracing rather than assuming:
cuda-lib'simplpin, which was 11 commits behindcuda-implmain.cuda-impl's ownmainalready pinned3e38c85, so the CUDA path resolved to a third kernels commit that neither leaf repo pointed at directly.#78was missing too, and the CPU path was itself one behind kernelsmain(be7be08, predating tools: restore consolidate.sh onto the consolidated main #79).Final state — all six repos on one kernels commit
What the cascade carries
diag_bending/diag_allcorner cross-term correctness fix (12 terms, 6 functions)reg_flowbending==0 Lamé dispatch routing#pragma onceinclude guardsrestrict.h→batch.hinclude forindex2sub(unblocks g++ entirely)Verification
test_reg_field19250 checks,test_reg_flow16347, both including the new regression tests).1df9fd3, with identical check counts both ways.build-via-cuda-libpassed on cuda-impl#48 (5c68cf9) and cuda-impl#49 (83fa026), and cuda-lib#47's ownbuildjob passed at2b2ad55— each a realmake -C . -j2 CXX=clang++ CXXFLAGS="-std=c++14 -O1".-O1and the splitMODULESlist are untouched.Pin hygiene
Both pins are the squash-merge commits on their repos'
main, not pre-merge branch heads. Every gitlink in the chain was verified to resolve withgit cat-file -ebefore opening this PR — the check caught one stale local view, which was a missing fetch rather than a dangling pin.🤖 Generated with Claude Code
https://claude.ai/code/session_016AjQcY78NgbagPSbPJRr6Z
Generated by Claude Code