') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [CDTOOL-1193] Support for Logging Endpoint Errors by rcaril · Pull Request #1721 · fastly/cli · GitHub
Skip to content

[CDTOOL-1193] Support for Logging Endpoint Errors - #1721

Merged
anthony-gomez-fastly merged 4 commits into
mainfrom
rcaril/CDTOOL-1193-support-for-logging-endpoint-errors
Apr 10, 2026
Merged

[CDTOOL-1193] Support for Logging Endpoint Errors#1721
anthony-gomez-fastly merged 4 commits into
mainfrom
rcaril/CDTOOL-1193-support-for-logging-endpoint-errors

Conversation

@rcaril

@rcarilrcaril commented Apr 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Change summary

This PR adds support for the service logging debug commands, which streams logging endpoint errors.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
 make test TEST_ARGS="-run TestParseLoggingError ./pkg/commands/service/logging/debug"
ok github.com/fastly/cli/pkg/commands/service/logging/debug 1.017s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Example Output:

INFO: Streaming logging endpoint errors for service <SID>
14:55:10 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host
14:55:21 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host
14:55:24 | Broken Log | Get "https://my-broken.logging.org/.well-known/fastly/logging/challenge": lookup my-broken.logging.org. on 127.0.0.1:53: no such host

Note: Claude Code was leveraged to build this feature

@rcaril
rcarilforce-pushed the rcaril/CDTOOL-1193-support-for-logging-endpoint-errors branch from 298e131 to 020be64CompareApril 9, 2026 19:17
@rcaril
rcaril marked this pull request as ready for review April 9, 2026 19:19
@rcaril
rcaril requested a review from a team as a code ownerApril 9, 2026 19:19
kpfleming
kpfleming approved these changes Apr 9, 2026
View reviewed changes

@kpflemingkpfleming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is, but I've suggested some minor improvements.

Comment threadpkg/commands/service/logging/debug/root.go Outdated
Comment threadpkg/commands/service/logging/debug/root.go Outdated
anthony-gomez-fastly
anthony-gomez-fastly approved these changes Apr 10, 2026
View reviewed changes

@anthony-gomez-fastlyanthony-gomez-fastly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthony-gomez-fastly
anthony-gomez-fastly enabled auto-merge (squash) April 10, 2026 16:58
@anthony-gomez-fastly
anthony-gomez-fastly merged commit 79c36fa into mainApr 10, 2026
13 checks passed
@anthony-gomez-fastly
anthony-gomez-fastly deleted the rcaril/CDTOOL-1193-support-for-logging-endpoint-errors branch April 10, 2026 17:02
@BrewTestBotBrewTestBot mentioned this pull request Apr 10, 2026
Merged
jedisct1 added a commit to dip-proto/fastly-cli that referenced this pull request Apr 14, 2026
@jedisct1
Merge branch 'main' into jsruntimes
755e1a8
* main:
build(deps): bump the go-dependencies group with 5 updates (fastly#1726)
release 14.3.1 (fastly#1725)
Restore permission for trusted publishing (fastly#1724)
Release 14.3.0 (fastly#1723)
[CDTOOL-1193] Support for Logging Endpoint Errors (fastly#1721)
chore(deps): bump go-fastly to 14.2.0 (fastly#1722)
Add --json / -j flag to all stats subcommands (fastly#1719)
build(deps): bump the go-dependencies group with 4 updates (fastly#1720)
Add "auth revoke" subcommand for token revocation (fastly#1717)
Restrict GitHub Actions workflow permissions to least privilege (fastly#1718)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpflemingkpflemingkpfleming approved these changes
@anthony-gomez-fastlyanthony-gomez-fastlyanthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril@kpfleming@anthony-gomez-fastly