') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Restore permission for trusted publishing by harmony7 · Pull Request #1724 · fastly/cli · GitHub
Skip to content

Restore permission for trusted publishing - #1724

Merged
anthony-gomez-fastly merged 1 commit into
mainfrom
kats/trusted-publishing-permission-fix
Apr 13, 2026
Merged

Restore permission for trusted publishing#1724
anthony-gomez-fastly merged 1 commit into
mainfrom
kats/trusted-publishing-permission-fix

Conversation

@harmony7

@harmony7harmony7 commented Apr 11, 2026

Copy link
Copy Markdown
Member

Change summary

This PR restores a permission in the workflow that had been removed in #1718 that is needed for publishing to NPM.

Publishing to NPM using trusted publishing requires id-token: write as added in #1644.

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Are there any considerations that need to be addressed for release?

A new point release (14.3.1) would be needed to get this version into NPM.

@harmony7
harmony7 requested a review from a team as a code ownerApril 11, 2026 00:28
@anthony-gomez-fastlyanthony-gomez-fastly added the Skip-Changelog do not add a changelog entry for this change label Apr 13, 2026
@anthony-gomez-fastly
anthony-gomez-fastly enabled auto-merge (squash) April 13, 2026 13:01
@anthony-gomez-fastly
anthony-gomez-fastly merged commit e90d690 into mainApr 13, 2026
20 of 21 checks passed
@anthony-gomez-fastly
anthony-gomez-fastly deleted the kats/trusted-publishing-permission-fix branch April 13, 2026 13:13
@BrewTestBotBrewTestBot mentioned this pull request Apr 13, 2026
Merged
jedisct1 added a commit to dip-proto/fastly-cli that referenced this pull request Apr 14, 2026
@jedisct1
Merge branch 'main' into jsruntimes
755e1a8
* main:
build(deps): bump the go-dependencies group with 5 updates (fastly#1726)
release 14.3.1 (fastly#1725)
Restore permission for trusted publishing (fastly#1724)
Release 14.3.0 (fastly#1723)
[CDTOOL-1193] Support for Logging Endpoint Errors (fastly#1721)
chore(deps): bump go-fastly to 14.2.0 (fastly#1722)
Add --json / -j flag to all stats subcommands (fastly#1719)
build(deps): bump the go-dependencies group with 4 updates (fastly#1720)
Add "auth revoke" subcommand for token revocation (fastly#1717)
Restrict GitHub Actions workflow permissions to least privilege (fastly#1718)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-gomez-fastlyanthony-gomez-fastlyanthony-gomez-fastly approved these changes
@philippschultephilippschulteAwaiting requested review from philippschultephilippschulte is a code owner automatically assigned from fastly/developer-tools

Assignees

No one assigned

Labels

Skip-Changelogdo not add a changelog entry for this change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harmony7@anthony-gomez-fastly