Skip to content

Update SSRC API client - #2457

Merged
erikeldridge merged 6 commits into
ssrcfrom
ssrc-client-internals
Feb 20, 2024
Merged

Update SSRC API client#2457
erikeldridge merged 6 commits into
ssrcfrom
ssrc-client-internals

Conversation

@erikeldridge

@erikeldridgeerikeldridge commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Internal client updates.

This is based on PR #2456, which defined the API.

Discussion

Working with @lahirumaramba and @trekforever.

Testing

Ran npm test and all tests pass.

@erikeldridgeerikeldridge mentioned this pull request Feb 13, 2024
Merged
erikeldridge
erikeldridge commented Feb 14, 2024
View reviewed changes
Comment threadsrc/remote-config/remote-config-api-client-internal.ts
// Remote Config backend constants
const FIREBASE_REMOTE_CONFIG_V1_API = 'https://firebaseremoteconfig.googleapis.com/v1';
// Honors env param to enable URL override independent of binary change.
const FIREBASE_REMOTE_CONFIG_URL_BASE = process.env.FIREBASE_REMOTE_CONFIG_URL_BASE || 'https://firebaseremoteconfig.googleapis.com';

@erikeldridgeerikeldridgeFeb 14, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lahirumaramba I've found it helpful here and in the Web SDK to be able to point the SDK at a local server for testing while in development, and issue reproduction after release. I don't see other references to process.env in this SDK, though. Do you have a preferred way to reference an env var?

@lahirumarambalahirumarambaFeb 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense to me. We use process.env to handle other env variables

firebase-admin-node/src/storage/storage.ts

Line 48 in 5fe4118

if(!process.env.STORAGE_EMULATOR_HOST&&process.env.FIREBASE_STORAGE_EMULATOR_HOST){

Let's make a note to document this new env var in our public docs

@erikeldridgeerikeldridgeFeb 20, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a row to our burndown to document this env var.

Base automatically changed from ssrc-api to ssrcFebruary 14, 2024 19:24
lahirumaramba
lahirumaramba approved these changes Feb 15, 2024
View reviewed changes

@lahirumarambalahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Comment threadsrc/remote-config/remote-config-api-client-internal.ts
// Remote Config backend constants
const FIREBASE_REMOTE_CONFIG_V1_API = 'https://firebaseremoteconfig.googleapis.com/v1';
// Honors env param to enable URL override independent of binary change.
const FIREBASE_REMOTE_CONFIG_URL_BASE = process.env.FIREBASE_REMOTE_CONFIG_URL_BASE || 'https://firebaseremoteconfig.googleapis.com';

@lahirumarambalahirumarambaFeb 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes sense to me. We use process.env to handle other env variables

firebase-admin-node/src/storage/storage.ts

Line 48 in 5fe4118

if(!process.env.STORAGE_EMULATOR_HOST&&process.env.FIREBASE_STORAGE_EMULATOR_HOST){

Let's make a note to document this new env var in our public docs

Comment threadsrc/remote-config/remote-config-api.ts
* Interface representing a Remote Config condition in the data-plane.
* A condition targets a specific group of users. A list of these conditions make up
* part of a Remote Config template.
*/

@lahirumarambalahirumarambaFeb 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get TW reviews on these. Thanks!

@erikeldridgeerikeldridgeFeb 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Good point. I was focused on this being an internal client and overlooked that it updated the API. I've added @jenh as a reviewer.

jenh
jenh suggested changes Feb 15, 2024
View reviewed changes

@jenhjenh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes.

Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config-api-client-internal.ts Outdated
@erikeldridge

erikeldridge commented Feb 20, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you for reviewing, @lahirumaramba, @jenh!

@jenh, I've updated the PR with your suggested changes and re-requested review from you.

@erikeldridge
erikeldridge merged commit aed5646 into ssrcFeb 20, 2024
@erikeldridge
erikeldridge deleted the ssrc-client-internals branch February 20, 2024 16:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumarambalahirumarambalahirumaramba approved these changes
+1 more reviewer
@jenhjenhjenh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@erikeldridgeerikeldridge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erikeldridge@lahirumaramba@jenh@trekforever