Skip to content

Add public SSRC methods - #2458

Merged
erikeldridge merged 14 commits into
ssrcfrom
ssrc-rc
Mar 5, 2024
Merged

Add public SSRC methods#2458
erikeldridge merged 14 commits into
ssrcfrom
ssrc-rc

Conversation

@erikeldridge

@erikeldridgeerikeldridge commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

Internal client updates.

This is based on PR #2457, which updated the API client.

Discussion

Working with @lahirumaramba and @trekforever.

Testing

Ran npm test and all tests pass.

erikeldridge
erikeldridge commented Feb 14, 2024
View reviewed changes
Comment threadsrc/remote-config/remote-config.ts Outdated
@erikeldridgeerikeldridge self-assigned this Feb 14, 2024
erikeldridge
erikeldridge commented Feb 14, 2024
View reviewed changes
Comment threadsrc/remote-config/remote-config-api.ts
jenh
jenh suggested changes Feb 14, 2024
View reviewed changes
Comment threadsrc/remote-config/remote-config-api.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadtest/integration/remote-config.spec.ts Outdated
Comment threadtest/integration/remote-config.spec.ts Outdated
Base automatically changed from ssrc-client-internals to ssrcFebruary 20, 2024 16:51
@erikeldridge

erikeldridge commented Feb 20, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you for reviewing, @jenh. I've updated this PR with your suggested changes.

jenh
jenh approved these changes Feb 20, 2024
View reviewed changes
Comment threadtest/unit/remote-config/remote-config.spec.ts Outdated
Comment threadtest/unit/remote-config/remote-config.spec.ts Outdated
@erikeldridge@jenh
Apply suggestions from code review
e6e5779
Co-authored-by: jen_h <harveyjen@google.com>
This was referenced Feb 27, 2024
Closed
Merged
lahirumaramba
lahirumaramba approved these changes Mar 5, 2024
View reviewed changes

@lahirumarambalahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the logging offline. LGTM!

Comment threadsrc/remote-config/remote-config-api.ts
Comment threadsrc/remote-config/remote-config.ts Outdated
Comment threadsrc/remote-config/remote-config.ts Outdated
@erikeldridge
erikeldridge merged commit 5c9b649 into ssrcMar 5, 2024
@erikeldridge
erikeldridge deleted the ssrc-rc branch March 5, 2024 22:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumarambalahirumarambalahirumaramba approved these changes
+1 more reviewer
@jenhjenhjenh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@erikeldridgeerikeldridge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erikeldridge@lahirumaramba@jenh@trekforever