Uh oh!
There was an error while loading. Please reload this page.
Implemented createRulesFileFromSource() and createRuleset() APIs - #607
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ryanpbrewster
commented
Jul 29, 2019
I do not think the link in your PR description is correct, that issue does not seem relevant to this PR. |
hiranya911
commented
Jul 29, 2019
Thanks @ryanpbrewster. Made the suggested changes and updated the issue description. |
Uh oh!
There was an error while loading. Please reload this page.
rachelmyers
left a comment
There was a problem hiding this comment.
Left some comments and questions in line. LGTM. 
Uh oh!
There was an error while loading. Please reload this page.
| readonly files: RulesFile[]; | ||
| }; | ||
| } | ||
There was a problem hiding this comment.
Are you removing these in favor of defining them in security-rules/security-rules-api-client.ts because they are set by the API?
There was a problem hiding this comment.
Correct. They are being moved to the api-client module, which in this case is treated as an internal implementation module.
* Implementing the Firebase Security Rules API (#604) * Implementing the Firebase Security Rules API * More argument validation and assertions * Cleaning up the rules impl * Internal API renamed * Fixing a typo in a comment * Implemented createRulesFileFromSource() and createRuleset() APIs (#607) * Implementing the Firebase Security Rules API * More argument validation and assertions * Adding the rest of the CRUD operations for rulesets * Cleaning up the rules impl * Cleaned up tests * Adding some missing comments * Removing support for multiple rules files in create() * Implemented the deleteRuleset() API (#609) * Added deleteRuleset API * Merged with source * Implemented the API for releasing rulesets (#610) * Implemented the API for releasing rulesets * Removed createRelease logic * Updated comment * Added the getStorageRuleset() API (#613) * Implemented the API for releasing rulesets * Removed createRelease logic * Added getStorageRules() API * Removed some redundant tests * Implementing the remaining releaseRuleset APIs (#616) * Implemented the listRulesetMetadata() API (#622) * Adding the rules API to the public API surface (#625) * Added rules API to the public admin namespace * Updated docs * Addressing comments regarding the d.ts file * Updated App typings * Rules integration tests (#633) * Rules integration tests * Refactored by adding some helper methods * Cleaned up some conditionals * Added verification for deleteRuleset test * Renamed tempRulesets * Handling ruleset limit exceeded error (#636) * Fixing alignment of an annotation * Updated comments
In addition to the above 2 new methods, I'm also refactoring the implementation a bit based on the feedback received in #604
SecurityRulesApiClientnow closely resembles the REST API.getRuleset()createRuleset()getRelease()SecurityRulesclass is now mostly a thin wrapper aroundSecurityRulesApiClient.