Rules integration tests

[hiranya911]

Integration tests that run against the production service:

$ npm run test:integration -- --grep securityRules
> firebase-admin@8.3.0 test:integration ~/Projects/firebase-admin-node/public
> mocha test/integration/*.ts --slow 5000 --timeout 20000 --require ts-node/register "--grep" "securityRules"
admin.securityRules
createRulesFileFromSource()
✓ creates a RulesFile from the source string
✓ creates a RulesFile from the source Buffer
createRuleset()
✓ creates a new Ruleset from a given RulesFile
✓ rejects with invalid-argument when the source is invalid
getRuleset()
✓ rejects with not-found when the Ruleset does not exist
✓ rejects with invalid-argument when the Ruleset name is invalid
✓ resolves with existing Ruleset
Cloud Firestore
✓ getFirestoreRuleset() returns the Ruleset currently in effect
✓ releaseFirestoreRulesetFromSource() applies the specified Ruleset to Firestore
Cloud Storage
✓ getStorageRuleset() returns the currently applied Storage rules
✓ releaseStorageRulesetFromSource() applies the specified Ruleset to Storage
listRulesetMetadata()
✓ lists all available Rulesets in pages
✓ lists the specified number of Rulesets
deleteRuleset()
✓ rejects with not-found when the Ruleset does not exist
✓ rejects with invalid-argument when the Ruleset name is invalid
✓ deletes existing Ruleset
16 passing (9s)

[ryanpbrewster]

tests look okay, they're a bit hard to follow

recommend introducing either:

• helper methods that keep track of which resources need to be cleaned up
• make the cleanup remove all rulesets + releases (using relevant ListXyz apis)

[hiranya911]

Added some helper functions to improve the readability. PTAL.

[ryanpbrewster]

only nits, I still feel like the test cleanup is quite difficult to reason about but it's not worth blocking on

[rachelmyers]

I suggested a rename for tempRulesets and have a question about the last test, but LGTM!

[hiranya911]

Renamed tempRulesets to rulesetsToDelete, and added a verification/assertion to the deleteRuleset() test case.