Skip to content

Test using pip install Firedrake - #215

Merged
JHopeCollins merged 12 commits into
JHopeCollins/dependabotfrom
JHopeCollins/ci-pip-container
Jun 17, 2025
Merged

JHopeCollins merged 12 commits into
JHopeCollins/dependabotfrom
JHopeCollins/ci-pip-container

Conversation

@JHopeCollins

@JHopeCollins JHopeCollins commented Feb 20, 2025

Copy link
Copy Markdown
Member

Update our CI ready for pip install firedrake to land in firedrakeproject/firedrake#4011
See the equivalent Gusto PR for details firedrakeproject/gusto#618

@JHopeCollins JHopeCollins added tests unit or integration tests upstream Issue related to upstream dependencies PRIORITY Needs urgent attention labels Feb 20, 2025
@JHopeCollins JHopeCollins self-assigned this Feb 20, 2025
@JHopeCollins
JHopeCollins changed the base branch from master to JHopeCollins/dependabot February 20, 2025 18:12
@connorjward

Copy link
Copy Markdown

work out how to use a matrix strategy to reduce the boiler plate of running tests with each nprocs=? value

Unfortunately you can't use the matrix part of a workflow to make this happen because that produces multiple jobs (which start from scratch) whereas we need multiple steps. The best strategy might be another bash script.

* import OptionsManager from petsctools

* FunctionSpace.subspaces not subfunctions

* pc.getOptionsPrefix now defaults to None not ''

* splitting TensorProductElements in unmixed spaces seems to work again now!

* pass quadrature_degree properly to project
@JHopeCollins
JHopeCollins merged commit 8b0087a into JHopeCollins/dependabot Jun 17, 2025
@JHopeCollins
JHopeCollins deleted the JHopeCollins/ci-pip-container branch June 17, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PRIORITY Needs urgent attention tests unit or integration tests upstream Issue related to upstream dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants