pip install firedrake - #4011
Merged
Merged
Conversation
|
|
This was referenced Feb 6, 2025
JHopeCollins
requested changes
Feb 21, 2025
lrtfm
suggested changes
Feb 23, 2025
dham
reviewed
Feb 24, 2025
JHopeCollins
previously requested changes
Feb 25, 2025
connorjward
marked this pull request as ready for review
February 26, 2025 10:58
connorjward
commented
Feb 26, 2025
Contributor
|
I just tried installing petsc using the most recent Here is the attached |
Member
It should be: See the discussion here and the updated installation doc page |
ddundo
added a commit
to mesh-adaptation/docs
that referenced
this pull request
Mar 4, 2025
… install` (#114) Firedrake is now installable via `pip`, with `firedrake-install` now giving a `FutureWarning`. For an overview of changes on Firedrake side, see firedrakeproject/firedrake#4011. This PR updates the `firedrake-parmmg` image and `reusable_test_suite.yml` workflows to conform to those changes, as described below. General: - The `firedrake-parmmg` image is now only 2.4GB and the build time is almost twice as fast (25 min faster)! - Mesh adaptation repos are now cloned to the home directory (they used to be under `/home/firedrake/firedrake/src`). Firedrake made this change in their containers too so I am just following their structure. - It is no longer necessary to create a virtual environment, so I don't create one (to be consistent with Firedrake's containers again). Dependencies: - We used to install [hypre](https://petsc.org/release/manualpages/PC/PCHYPRE/) (it's listed in our [petsc-configure-options.txt](https://github.com/mesh-adaptation/docs/blob/main/install/petsc_configure_options.txt)) but I don't think we need this so I do not install it here. - Firedrake installs https://github.com/firedrakeproject/slepc in their vanilla container, but we didn't have this in our old containers so I don't install it now either. - Firedrake no longer installs `vtk` by default, so I added it to dependencies of packages. Parallel tests: - I realised that parallel tests did not contribute to the coverage report. This is now fixed. - The container now ships OpenMPI, so we can't run serial and parallel tests with a single `pytest` call. - Parallel tests are now run with `mpiexec -n N python3 -m pytest ...`, which is strongly discouraged to be executed as root (see https://docs.open-mpi.org/en/v5.0.x/man-openmpi/man1/mpirun.1.html#the-allow-run-as-root-option), which we do in `reusable_test_suite.yml`. Long story short, I think this is fine to do in our workflow since it uses a container so we're not really concerned about something going wrong. - The `reusable_test_suite.yml` now runs serial and parallel tests in two separate steps, and the coverage report is generated in a further separate step. Related PRs: - Animate: mesh-adaptation/animate#175 - Goalie: mesh-adaptation/goalie#291 - Movement: mesh-adaptation/movement#159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Die
firedrake-install! Die! Die! Die!Remaining tasks
make checkUser-facing changes
pip install firedrakepip.firedrake-configurescript to facilitate installation.firedrake-install/firedrake-updateremain but spit out a deprecation warning.firedrake-install --doiwill no longer work.Docker
firedrake-vanillaandfiredrake-complexhave been renamed tofiredrake-vanilla-defaultandfiredrake-vanilla-complexrespectively.firedrakeis now installed directly in the container. It is no longer necessary to activate a virtual environment.firedrakerepository is now installed in~/firedrakeinstead of~/firedrake/src/firedrake. The same applies to other packages likegustoandthetisinside thefiredrakeproject/firedrakecontainer.firedrake-vanillacontainers. If your package needs it then please add it to your ownpyproject.tomlor runpip install vtk.Please see firedrakeproject/gusto#618 as an example switching a workflow to using the new containers.
Developer-facing changes
firedrake-envcontainer no longer contains PETSc, which is instead built infiredrake-vanilla.firedrake-envcontainer.Design choices
Unlike
firedrake-install,firedrake-configureis designed to be very, very dumb. All it does is take in a specification of a desired package manager (apt-x86_64,apt-aarch64,brew-arm64) and "arch" (defaultorcomplex) and spits out a string of appropriate system dependencies (--show-system-dependencies) or PETSc configure options (--show-petsc-configure-options). You can also pass--no-package-managerif you aren't using a supported system and this will give you a set of PETSc configure options where everything is downloaded.