Conversation
Since VTK does not have an ARM wheel most downstream packages are not usable.
connorjward
reviewed
Feb 26, 2025
|
|
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
Contributor
Author
|
Closing this PR in favor of a cleaner git history. The changes introduced here (adding smoke tests to the spyro library) are included in a new PR with improved commit organization. Thanks for the feedback and reviews so far! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some quick smoke tests for spyro. Should not take more than 2 minutes. Can only be merged after PR##4011 and PR NDF-Poli-USP/spyro#145