Skip to content

Modernize more of the transform functions - #5934

Merged
mstange merged 3 commits into
firefox-devtools:mainfrom
mstange:push-rpnlzllzpywq
Apr 7, 2026
Merged

Modernize more of the transform functions#5934
mstange merged 3 commits into
firefox-devtools:mainfrom
mstange:push-rpnlzllzpywq

Conversation

@mstange

@mstangemstange commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Two changes:

  • Use createStackTableBySkippingDiscarded in focusSubtree, focusFunction, and focusCategory.
  • Change mergeCallNode to only create a new prefix column, like mergeFunction.

@mstange
mstange requested a review from canovaApril 2, 2026 15:53
@mstangemstange self-assigned this Apr 2, 2026
@codecov

codecovBot commented Apr 2, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.45%. Comparing base (bc32214) to head (46e3594).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5934 +/- ##
=======================================
Coverage 85.45% 85.45% =======================================
Files 321 321 Lines 32068 32068 Branches 8829 8745 -84 =======================================
Hits 27403 27403 Misses 4234 4234 Partials 431 431

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

canova
canova approved these changes Apr 7, 2026
View reviewed changes

@canovacanova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mstange
mstange enabled auto-merge April 7, 2026 17:08
@mstange
mstange merged commit ac19bf3 into firefox-devtools:mainApr 7, 2026
19 checks passed
@fatadelfatadel mentioned this pull request Apr 28, 2026
Merged
fatadel added a commit that referenced this pull request Apr 28, 2026
@fatadel
Deploy April 28, 2026 (#5980)
9238c7e
Changes:
[Nazım Can Altınova] Add Adel to the automatic dependency reviews
(#5930)
[fatadel] Fix arrow panel appearing behind marker tooltips (#5926)
[fatadel] Upgrade Node.js from v22 to v24 (#5923)
[Markus Stange] Use createStackTableBySkippingDiscarded in focusSelf.
(#5916)
[Markus Stange] Propagate isJS to symbolicated funcs (#5907)
[Markus Stange] Always render the CPU-usage-aware activity graph when
CPU information is available (#5918)
[Nazım Can Altınova] Fallback to javascript highlighting in the source
view as a backup (#5936)
[Nazım Can Altınova] Properly type the return value of
_languageExtForPath (#5937)
[Nazım Can Altınova] Update typescript eslint dependencies (#5938)
[Markus Stange] Modernize more of the transform functions (#5934)
[Paul Adenot] Fix extractGeckoLogs for structured Log marker format (bug
2022540) (#5927)
[Nazım Can Altınova] Move some profile fetching code into a separate
module. (#5939)
[Markus Stange] Update the hovered item when panning any viewport canvas
(#5903)
[Markus Stange] Migrate Home page animation to CSS transitions and
remove react-transition-group (#5649)
[Nazım Can Altınova] Fix test/lint commands on Windows and fix CI
(#5947)
[Nazım Can Altınova] Convert profile-logic/js-tracer.tsx to a ts file
(#5942)
[Markus Stange] Remove panelLayoutGeneration (#5946)
[fatadel] Add CounterDisplayConfig to counters in the processed profile
format (#5912)
[Nazım Can Altınova] Fix eslint-config-prettier silently overriding
custom rules (#5955)
[fatadel] Dim non-matching nodes in the stack chart when searching
(#5935)
[Nazım Can Altınova] Fix loading .json.gz profiles from inside zip
archives (#5959)
[Ryan Hunt] Add a fullscreen button to the bottom box (#5605)
[Markus Stange] Speed up _computeCallNodeTableHierarchy by keeping
siblings ordered by func (#5964)
[Markus Stange] Replace symbolicator-cli with a profiler-edit node tool
(#5965)
[Nazım Can Altınova] Add "Include idle samples" toggle to the call tree
settings (#5968)
[Nazım Can Altınova] Add dark mode versions of the fullscreen icons
(#5972)
[fatadel] Replace 4 counter track components with a single generic
TrackCounter (#5944)
[fatadel] Use ephemeral port for esbuild's internal dev server (#5974)
[carverdamien] Remove category from LongTaskMarkerPayload (#5975)
And special thanks to our localizers:
de: Ger de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy ru: berry sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423 zh-CN: wxie zh-TW: Pin-guang Chen
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canovacanovacanova approved these changes

Assignees

@mstangemstange

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mstange@canova