Skip to content

Remove category from LongTaskMarkerPayload - #5975

Merged
carverdamien merged 2 commits into
firefox-devtools:mainfrom
carverdamien:bug/2023960
Apr 28, 2026
Merged

Remove category from LongTaskMarkerPayload#5975
carverdamien merged 2 commits into
firefox-devtools:mainfrom
carverdamien:bug/2023960

Conversation

@carverdamien

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.25%. Comparing base (c155fdf) to head (959f4cc).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5975 +/- ##
==========================================
- Coverage 85.33% 85.25% -0.09% 
==========================================
Files 323 317 -6 Lines 32262 31935 -327 Branches 8895 8842 -53 ==========================================
- Hits 27532 27226 -306 + Misses 4298 4277 -21 
Partials 432 432 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel

Copy link
Copy Markdown
Contributor

Any explanation? 😃

@carverdamien

Copy link
Copy Markdown
ContributorAuthor

Any explanation? 😃

I ran into it here
It's not used anymore. See discussion here

@carverdamien

Copy link
Copy Markdown
ContributorAuthor

I'm not sure if we can remove all category in marker.ts?

@fatadel

Copy link
Copy Markdown
Contributor

Any explanation? 😃

I ran into it here It's not used anymore. See discussion here

For whatever reason, the discussion link does not work. I am attaching the actual discussion here for the context.

image

@fatadel

Copy link
Copy Markdown
Contributor

I'm not sure if we can remove all category in marker.ts?

I am not sure either.

@fatadel
fatadel self-requested a review April 28, 2026 12:48
@carverdamien
carverdamien merged commit 59d35be into firefox-devtools:mainApr 28, 2026
20 of 21 checks passed
@canova

Copy link
Copy Markdown
Member

(Also it would be good to add a link to the bugzilla side and/or to the Firefox patch to the first PR message whenever we are doing cross repo work so we can see the cross references)

I'm not sure if we can remove all category in marker.ts?

I would say that we need to audit all of them that have a category one by one to see if we still have them in the gecko side. But from a quick glance, mostly yes.

@fatadelfatadel mentioned this pull request Apr 28, 2026
fatadel added a commit that referenced this pull request Apr 28, 2026
Changes:
[Nazım Can Altınova] Add Adel to the automatic dependency reviews
(#5930)
[fatadel] Fix arrow panel appearing behind marker tooltips (#5926)
[fatadel] Upgrade Node.js from v22 to v24 (#5923)
[Markus Stange] Use createStackTableBySkippingDiscarded in focusSelf.
(#5916)
[Markus Stange] Propagate isJS to symbolicated funcs (#5907)
[Markus Stange] Always render the CPU-usage-aware activity graph when
CPU information is available (#5918)
[Nazım Can Altınova] Fallback to javascript highlighting in the source
view as a backup (#5936)
[Nazım Can Altınova] Properly type the return value of
_languageExtForPath (#5937)
[Nazım Can Altınova] Update typescript eslint dependencies (#5938)
[Markus Stange] Modernize more of the transform functions (#5934)
[Paul Adenot] Fix extractGeckoLogs for structured Log marker format (bug
2022540) (#5927)
[Nazım Can Altınova] Move some profile fetching code into a separate
module. (#5939)
[Markus Stange] Update the hovered item when panning any viewport canvas
(#5903)
[Markus Stange] Migrate Home page animation to CSS transitions and
remove react-transition-group (#5649)
[Nazım Can Altınova] Fix test/lint commands on Windows and fix CI
(#5947)
[Nazım Can Altınova] Convert profile-logic/js-tracer.tsx to a ts file
(#5942)
[Markus Stange] Remove panelLayoutGeneration (#5946)
[fatadel] Add CounterDisplayConfig to counters in the processed profile
format (#5912)
[Nazım Can Altınova] Fix eslint-config-prettier silently overriding
custom rules (#5955)
[fatadel] Dim non-matching nodes in the stack chart when searching
(#5935)
[Nazım Can Altınova] Fix loading .json.gz profiles from inside zip
archives (#5959)
[Ryan Hunt] Add a fullscreen button to the bottom box (#5605)
[Markus Stange] Speed up _computeCallNodeTableHierarchy by keeping
siblings ordered by func (#5964)
[Markus Stange] Replace symbolicator-cli with a profiler-edit node tool
(#5965)
[Nazım Can Altınova] Add "Include idle samples" toggle to the call tree
settings (#5968)
[Nazım Can Altınova] Add dark mode versions of the fullscreen icons
(#5972)
[fatadel] Replace 4 counter track components with a single generic
TrackCounter (#5944)
[fatadel] Use ephemeral port for esbuild's internal dev server (#5974)
[carverdamien] Remove category from LongTaskMarkerPayload (#5975)
And special thanks to our localizers:
de: Ger de: Michael Köhler el: Jim Spentzos en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy ru: berry sv-SE: Andreas Pettersson tr: Grk zh-CN: Olvcpr423 zh-CN: wxie zh-TW: Pin-guang Chen
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@carverdamien@fatadel@canova