Update isLocalURL to include LAN addresses, .local domains, and hostn… by cathaysia · Pull Request #5973 · firefox-devtools/profiler

cathaysia · 2026-04-28T07:30:36Z

Treat non-public addresses—such as loopback addresses, LAN addresses, and CGNAT addresses—as local addresses; this allows for direct access to computers within the local network, Tailscale and etc..

codecov · 2026-04-30T10:03:23Z

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.78%. Comparing base (52f65d8) to head (3f028f9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
src/utils/url.ts	96.42%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #5973 +/- ##
==========================================
+ Coverage 83.77% 83.78% +0.01% 
==========================================
Files 329 329 Lines 34559 34587 +28 Branches 9574 9698 +124 ==========================================
+ Hits 28952 28979 +27 - Misses 5178 5179 +1 
Partials 429 429

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

canova

Thanks for the PR, adding some comments below.

…ames without dots

…hmark ranges

cathaysia · 2026-04-30T11:01:55Z

before:

after:

cathaysia · 2026-05-27T06:32:58Z

can this pr be merged?

fatadel · 2026-05-27T09:53:25Z

Hey @cathaysia, you need to re-request review when you've done working on the feedback. I'll do that for you now :)

cathaysia · 2026-05-27T09:54:33Z

thanks

canova

Oops, missed this one.

canova · 2026-05-27T10:46:31Z

+ /^127\./.test(hostname) || // Loopback 127.0.0.0/8
+ /^10\./.test(hostname) || // Private 10.0.0.0/8
+ /^172\.(1[6-9]|2[0-9]|3[0-1])\./.test(hostname) || // Private 172.16.0.0/12
+ /^192\.168\./.test(hostname) || // Private 192.168.0.0/16
+ /^100\.(6[4-9]|[7-9][0-9]|1[0-1][0-9]|12[0-7])\./.test(hostname) || // CGNAT 100.64.0.0/10
+ /^169\.254\./.test(hostname) || // Link-local 169.254.0.0/16
+ /^198\.(1[8-9])\./.test(hostname) // Benchmark 198.18.0.0/15


These match hostnames like:
192.168.1.1.foo.com
URL.hostname will happily return these host names. Please make sure that the host names are actually ipv4 addresses.

I updated the regex, could you please check it again?

canova

Thanks, looks good to me!

Changes: [Nazım Can Altınova] Fix call node context menu being hidden behind source view bottom box (#6045) [Nazım Can Altınova] Pass `--use-env-proxy` only when the node version is >= 24 (#6064) [fatadel] Upgrade @firefox-devtools/react-contextmenu to 5.2.4 (#6066) [Markus Stange] Switch profiler-edit from minimist to commander (#6065) [Markus Stange] Support reading profiles from JsonSlabs files (#6037) [Florian Quèze] Don't fail profile processing when a marker's stack field is not a backtrace (#6069) [fatadel] Replace the footer-links overlay with a settings menu (#6042) [fatadel] Upgrade @types/node to match Node 24 (#6070) [fatadel] Remove unused undici-types package (#6074) [cathaysia] Update isLocalURL to include LAN addresses, .local domains, and hostn… (#5973) [Markus Stange] Fix from-url with binary profiles (#6072) [fatadel] Upgrade to React 19 (#6067) [Markus Stange] Add an insertStackLabels helper. (#6076) [fatadel] Drive counter tooltips from a tooltipRows schema (#6023) [fatadel] Add TrackPower--tooltip-average-power-microwatt (#6080) [Markus Stange] Downgrade to React 19.1 to fix unusable dev build performance. (#6082) [Nazım Can Altınova] Add source map symbolication and source view support (#6018) [spokodev] fix(FilterNavigatorBar): clip overflow so many breadcrumbs do not expand the parent (#6085) [Markus Stange] Move paddings inside the tree header cells. (#6002) [Markus Stange] Add an --insert-label-frames argument to the profiler-edit tool (#5966) [Markus Stange] Stop printing "error: too many arguments" during tests. (#6088) [Markus Stange] More additions to profiler-edit, for sp3 profiles (#6009) [Nazım Can Altınova] Do not rely on localized texts in the settings menu tests (#6101) And special thanks to our localizers: be: Andrei Mukamolau de: Ger de: Michael Köhler de: Ralf Duehnfahr el: Jim Spentzos en-CA: chutten en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fr: wy fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl ru: Valery Ledovskoy sr: Марко Костић (Marko Kostić) sv-SE: Andreas Pettersson tr: Grk tr: Selim Şumlu zh-CN: Olvcpr423 zh-TW: Pin-guang Chen

cathaysia force-pushed the main branch 2 times, most recently from 38f05a1 to c5cad4dCompare April 28, 2026 07:34

canova reviewed Apr 30, 2026
View reviewed changes

Comment threadsrc/test/unit/url.test.ts
Comment threadsrc/utils/url.ts Outdated
Comment threadsrc/utils/url.ts Outdated
Comment threadsrc/utils/url.ts Outdated
Comment threadsrc/test/unit/url.test.ts

cathaysia force-pushed the main branch 2 times, most recently from 7dcfd1c to ee13e17Compare April 30, 2026 10:37

cathaysia added 3 commits April 30, 2026 18:59

Update isLocalURL to include LAN addresses, .local domains, and hostn…
11f8b4c
…ames without dots

Update isLocalURL to include IPv6 local addresses (Link-local and ULA)
8ee35b3

Further expand isLocalURL to include CGNAT, IPv4 link-local, and benc…
7e1b79c
…hmark ranges

cathaysia force-pushed the main branch from ee13e17 to 7b3c2f1Compare April 30, 2026 10:59

fatadel requested a review from canova May 27, 2026 09:53

canova requested changes May 27, 2026
View reviewed changes

cathaysia force-pushed the main branch 2 times, most recently from a76c6c5 to 1ae49e4Compare May 28, 2026 07:28

Apply suggestion
1956e23

cathaysia force-pushed the main branch from 1ae49e4 to 1956e23Compare May 28, 2026 07:39

cathaysia requested a review from canova June 1, 2026 07:43

canova approved these changes Jun 1, 2026
View reviewed changes

Merge branch 'main' into main
3f028f9

canova enabled auto-merge (squash) June 1, 2026 11:36

canova merged commit a16ebe4 into firefox-devtools:mainJun 1, 2026
21 checks passed

canova mentioned this pull request Jun 16, 2026
Deploy June 16, 2026 #6103
Merged

Uh oh!

Conversation

cathaysia commented Apr 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Apr 30, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

canova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cathaysia commented Apr 30, 2026

Uh oh!

cathaysia commented May 27, 2026

Uh oh!

fatadel commented May 27, 2026

Uh oh!

cathaysia commented May 27, 2026

Uh oh!

canova left a comment

Choose a reason for hiding this comment

Uh oh!

canovaMay 27, 2026

Choose a reason for hiding this comment

Uh oh!

cathaysiaMay 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

canova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cathaysia commented Apr 28, 2026•
edited
Loading

codecovBot commented Apr 30, 2026•
edited
Loading

cathaysiaMay 28, 2026•
edited
Loading