Uh oh!
There was an error while loading. Please reload this page.
Add an insertStackLabels helper. - #6076
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #6076 +/- ##
=======================================
Coverage 83.82% 83.82% =======================================
Files 330 330 Lines 34680 34682 +2 Branches 9608 9703 +95 =======================================
+ Hits 29070 29072 +2
Misses 5181 5181 Partials 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This takes an existing profile and creates label frames based on function name prefix matching. The label frames are inserted as parent stack nodes of the matched stack node. This lets us turn native profiles from e.g. samply into profiles where the JS-only view shows DOM calls.
b9f7919 to
53f9bf4Compare| const funcTable = shallowCloneFuncTable(oldFuncTable); | ||
| const stringTable = StringTable.withBackingArray(stringArray); | ||
| const rootLabelName = 'Root (unaccounted / catch-all)'; |
There was a problem hiding this comment.
What does unaccounted mean here? Anything other than the provided label frames?
There was a problem hiding this comment.
Yeah I really wasn't sure what to call this. Unaccounted here means that, if you look at the JS-only call tree in inverted mode, the self samples of this label are any samples that aren't covered by the provided label frames (or JS functions).
| } = profile.shared; | ||
| const frameTable = shallowCloneFrameTable(oldFrameTable); | ||
| const funcTable = shallowCloneFuncTable(oldFuncTable); | ||
| const stringTable = StringTable.withBackingArray(stringArray); |
There was a problem hiding this comment.
We shallow copy frame and func table but not the string array. Should we slice to keep this stringArray immutable?
There was a problem hiding this comment.
No I'd say mutating the stringArray by appending is fine - having unused strings in it doesn't really impact anything.
| const sourceIndex = funcTable.source[funcIndex]; | ||
| if (sourceIndex !== null) { | ||
| const filenameString = stringArray[sources.filename[sourceIndex]]; | ||
| nameString += ` (${filenameString})`; |
There was a problem hiding this comment.
Oh, I see what you mean now. It looks a bit wasteful to compute this for every func, but it's also probably fine for the node script.
I was actually thinking about doing this the other way around. Pre-processing the funcPrefixes array to split the name and file path, so they can be checked individually. But I didn't check the second PR that uses this yet, I don't know how feasible that is. I don't mind either way.
Uh oh!
There was an error while loading. Please reload this page.
Based on #6076. This lets us create profiles like https://share.firefox.dev/4mPPTgr with DOM label frames that show up in the JS-only view, for profiles from samply, based on function name matching. The matchers are declared in a toml file that is passed to the script. Example TOML file: https://gist.github.com/mstange/827c40404c987bc566b8b324efc0a04f
Changes: [Nazım Can Altınova] Fix call node context menu being hidden behind source view bottom box (#6045) [Nazım Can Altınova] Pass `--use-env-proxy` only when the node version is >= 24 (#6064) [fatadel] Upgrade @firefox-devtools/react-contextmenu to 5.2.4 (#6066) [Markus Stange] Switch profiler-edit from minimist to commander (#6065) [Markus Stange] Support reading profiles from JsonSlabs files (#6037) [Florian Quèze] Don't fail profile processing when a marker's stack field is not a backtrace (#6069) [fatadel] Replace the footer-links overlay with a settings menu (#6042) [fatadel] Upgrade @types/node to match Node 24 (#6070) [fatadel] Remove unused undici-types package (#6074) [cathaysia] Update isLocalURL to include LAN addresses, .local domains, and hostn… (#5973) [Markus Stange] Fix from-url with binary profiles (#6072) [fatadel] Upgrade to React 19 (#6067) [Markus Stange] Add an insertStackLabels helper. (#6076) [fatadel] Drive counter tooltips from a tooltipRows schema (#6023) [fatadel] Add TrackPower--tooltip-average-power-microwatt (#6080) [Markus Stange] Downgrade to React 19.1 to fix unusable dev build performance. (#6082) [Nazım Can Altınova] Add source map symbolication and source view support (#6018) [spokodev] fix(FilterNavigatorBar): clip overflow so many breadcrumbs do not expand the parent (#6085) [Markus Stange] Move paddings inside the tree header cells. (#6002) [Markus Stange] Add an --insert-label-frames argument to the profiler-edit tool (#5966) [Markus Stange] Stop printing "error: too many arguments" during tests. (#6088) [Markus Stange] More additions to profiler-edit, for sp3 profiles (#6009) [Nazım Can Altınova] Do not rely on localized texts in the settings menu tests (#6101) And special thanks to our localizers: be: Andrei Mukamolau de: Ger de: Michael Köhler de: Ralf Duehnfahr el: Jim Spentzos en-CA: chutten en-GB: Ian Neal es-CL: ravmn fr: Théo Chevalier fr: wy fur: Fabio Tomat fy-NL: Fjoerfoks ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl ru: Valery Ledovskoy sr: Марко Костић (Marko Kostić) sv-SE: Andreas Pettersson tr: Grk tr: Selim Şumlu zh-CN: Olvcpr423 zh-TW: Pin-guang Chen
This takes an existing profile and creates label frames based on function name prefix matching. The label frames are inserted as parent stack nodes of the matched stack node.
This lets us turn native profiles from e.g. samply into profiles where the JS-only view shows DOM calls.