Skip to content

Paper/README updates to match code. #216

Description

@sidxz

I am consolidating text-level things I encountered while checking the paper's claims against the code.
None of them are big, just needs updating.

  1. Table 1 and the sentence "All handle multidimensional data via axis" (and the README's "All methods can accept blocks of multidimensional data") include lineardiff, but it doesn't have an axis argument:

    lineardiff(np.stack([x, x]), dt, order=3, gamma=0.01, window_size=11, solver='CLARABEL', axis=1)
    # TypeError: lineardiff() got an unexpected keyword argument 'axis'

    Your savgoldiff uses axis 0 length when differentiating another axis #211 commit message already says "the other eleven axis-aware methods", so I guess the text just didn't get updated.

  2. State of the Field says the derivative package "lacks multidimensional support", but derivative.dxdt(x, t, kind, axis=0) does have an axis argument (and takes a t array). The NaN-handling and optimizer parts of that sentence look right to me.

  3. Affiliations: Please cross check that the authors match their respective affiliations, as mentioned in their ORCID.

Review reference: openjournals/joss-reviews#11172

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions