You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am consolidating text-level things I encountered while checking the paper's claims against the code.
None of them are big, just needs updating.
Table 1 and the sentence "All handle multidimensional data via axis" (and the README's "All methods can accept blocks of multidimensional data") include lineardiff, but it doesn't have an axis argument:
State of the Field says the derivative package "lacks multidimensional support", but derivative.dxdt(x, t, kind, axis=0) does have an axis argument (and takes a t array). The NaN-handling and optimizer parts of that sentence look right to me.
Affiliations: Please cross check that the authors match their respective affiliations, as mentioned in their ORCID.
I am consolidating text-level things I encountered while checking the paper's claims against the code.
None of them are big, just needs updating.
Table 1 and the sentence "All handle multidimensional data via
axis" (and the README's "All methods can accept blocks of multidimensional data") include lineardiff, but it doesn't have anaxisargument:Your savgoldiff uses axis 0 length when differentiating another axis #211 commit message already says "the other eleven axis-aware methods", so I guess the text just didn't get updated.
State of the Field says the
derivativepackage "lacks multidimensional support", butderivative.dxdt(x, t, kind, axis=0)does have anaxisargument (and takes atarray). The NaN-handling and optimizer parts of that sentence look right to me.Affiliations: Please cross check that the authors match their respective affiliations, as mentioned in their ORCID.
Review reference: openjournals/joss-reviews#11172