Skip to content

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle - #11982

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_segmented_control_test_migration
Jul 1, 2026
Merged

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle#11982
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_segmented_control_test_migration

Conversation

@Renzo-Olivares

@Renzo-OlivaresRenzo-Olivares commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart. Replaced SemanticsTester with SemanticsHandle.
  • Removed @Skip annotation, all tests in this file has passed. semantics_tester.dart has existed in cupertino_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jun 25, 2026
@github-actionsgithub-actionsBot added the triage-framework Should be looked at in framework triage label Jun 25, 2026
@Renzo-OlivaresRenzo-Olivares mentioned this pull request Jun 25, 2026
Open
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request unskips the segmented control test file and refactors the semantics test to use SemanticsHandle and individual semantics assertions instead of SemanticsTester. The reviewer identified that find.semantics is not a valid property on CommonFinders and recommended using find.bySemanticsLabel instead for the assertions.

Comment threadpackages/cupertino_ui/test/segmented_control_test.dart
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assistgemini-code-assistBotJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

 find.bySemanticsLabel('Child 1'),

@Renzo-OlivaresRenzo-OlivaresJun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment threadpackages/cupertino_ui/test/segmented_control_test.dart

// Assert Child 2 (unselected)
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assistgemini-code-assistBotJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

 find.bySemanticsLabel('Child 2'),

@Renzo-OlivaresRenzo-OlivaresJun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment threadpackages/cupertino_ui/test/segmented_control_test.dart
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assistgemini-code-assistBotJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

 find.bySemanticsLabel('Child 1'),

@Renzo-OlivaresRenzo-OlivaresJun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment threadpackages/cupertino_ui/test/segmented_control_test.dart

// Assert Child 2 (now selected and focused)
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assistgemini-code-assistBotJun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

 find.bySemanticsLabel('Child 2'),

@Renzo-OlivaresRenzo-OlivaresJun 25, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 25, 2026
@Renzo-OlivaresRenzo-Olivares added the CICD Run CI/CD label Jun 25, 2026
@Renzo-OlivaresRenzo-Olivares mentioned this pull request Jun 25, 2026
Closed
@PiinksPiinks changed the title [Decoupling] Migrate segmented_control_test.dart to SemanticsHandle[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandleJun 25, 2026
justinmc
justinmc approved these changes Jun 30, 2026
View reviewed changes

@justinmcjustinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus ensureSemantics 👍

Comment threadpackages/cupertino_ui/test/segmented_control_test.dart Outdated

testWidgets('Segmented control semantics', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

@justinmcjustinmcJun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensureSemantics is not needed.

@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 30, 2026
@Renzo-OlivaresRenzo-Olivares added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 30, 2026
@auto-submit
auto-submitBot merged commit 99a427a into flutter:mainJul 1, 2026
88 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 1, 2026
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 1, 2026
@engine-flutter-autoroll
Roll Packages from 274ed3e0f9f6 to e74210630ab8 (18 revisions) (flutt…
ca62cc7
…er#188863)
flutter/packages@274ed3e...e742106
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable
`tab_scaffold_test.dart` (flutter/packages#12064)
2026-07-01 jmccandless@google.com [material_ui] Port flutter/flutter
flutter#184808 "Remove semantics_tester import from card_test.dart"
(flutter/packages#11965)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`sliding_segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11979)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`route_test.dart` to `SemanticsHandle` (flutter/packages#11993)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11982)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable
`text_field_test.dart` (flutter/packages#12067)
2026-06-30 r.anantheswar@gmail.com [camera_android_camerax] Pass
targetVideoEncodingBitRate to Recorder (flutter/packages#11960)
2026-06-30 1063596+reidbaker@users.noreply.github.com
[camera_android_camerax] Migrate check-readiness skill from bash to Dart
(flutter/packages#11943)
2026-06-30 21270878+elliette@users.noreply.github.com [material_ui]
Enable `time_picker_test` (flutter/packages#12061)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065)
2026-06-30 64674824+yashas-hm@users.noreply.github.com [image_picker]
Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully
(flutter/packages#11825)
2026-06-30 faheemabbas766@gmail.com [cross_file] Document native
mimeType behavior (flutter/packages#11662)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `image_data.dart` imports from `circle_avatar_test.dart`,
`color_scheme_test.dart` (flutter/packages#12059)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Remove `image_data.dart` import from `scaffold_test.dart`
(flutter/packages#12060)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Remove widgets import from menu_anchor_test.dart
(flutter/packages#12068)
2026-06-30 21270878+elliette@users.noreply.github.com [material_ui]
Enable `checkbox_list_tile_test` (flutter/packages#12007)
2026-06-30 louisehsu@google.com [in_app_purchase_storekit] Expose
quantity in Transactions (flutter/packages#11879)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmcjustinmcjustinmc approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: cupertino_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Renzo-Olivares@justinmc@Piinks