Skip to content

[cupertino_ui] Remove widgets import from menu_anchor_test.dart - #12068

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_menu_anchor_test
Jun 30, 2026
Merged

[cupertino_ui] Remove widgets import from menu_anchor_test.dart#12068
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_menu_anchor_test

Conversation

@QuncCccccc

@QuncCcccccQuncCccccc commented Jun 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removes the cross-import of widgets/semantics_tester.dart from menu_anchor_test.dart.
  • Removes SemanticsTester usages.
  • Removes the @Skip annotation and moves the file to the test/ folder.
  • Updates two internal test helper constructors to satisfy analyzer after enabling the file: updated NestedTag and DebugCupertinoMenuEntry constructors to satisfy prefer_initializing_formals after the file became analyzed under test/. These helper changes are analyzer-only cleanup; without them, dart analyze --fatal-infos fails.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc
QuncCccccc requested a review from chunhtaiJune 30, 2026 01:07
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 30, 2026
@QuncCccccc
QuncCccccc requested a review from justinmcJune 30, 2026 01:07
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 30, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip annotation and refactors menu_anchor_test.dart to use SemanticsHandle and isSemantics assertions instead of SemanticsTester and hasSemantics. It also simplifies constructors in NestedTag and DebugCupertinoMenuEntry. The review feedback suggests utilizing addTearDown to handle the disposal of SemanticsHandle instances to ensure proper cleanup in case of test failures, and removing the corresponding manual disposal calls.

Comment threadpackages/cupertino_ui/test/menu_anchor_test.dart Outdated
Comment threadpackages/cupertino_ui/test/menu_anchor_test.dart Outdated
Comment threadpackages/cupertino_ui/test/menu_anchor_test.dart Outdated
Comment threadpackages/cupertino_ui/test/menu_anchor_test.dart Outdated
justinmc
justinmc approved these changes Jun 30, 2026
View reviewed changes

@justinmcjustinmc left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Gemini about addTearDown, otherwise LGTM 👍

Edit: Actually, per #12057 (comment) it looks like we don't need ensureSemantics at all.

@QuncCccccc
QuncCcccccforce-pushed the enable_cupertino_menu_anchor_test branch from 2983581 to 3aa4839CompareJune 30, 2026 18:49
@github-actionsgithub-actionsBot removed the CICD Run CI/CD label Jun 30, 2026
@QuncCcccccQuncCccccc added the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc

QuncCccccc commented Jun 30, 2026

Copy link
Copy Markdown
ContributorAuthor

Regarding Gemini's comment, I tried to use tearDown but it throws error:

The following assertion was thrown running a test:
A SemanticsHandle was active at the end of the test.
All SemanticsHandle instances must be disposed by calling dispose() on the SemanticsHandle.

But I removed ensureSemantics, so no need to handle it at all! Thanks for the suggestion!

@QuncCcccccQuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2026
@auto-submit
auto-submitBot merged commit 9ea8717 into flutter:mainJun 30, 2026
88 checks passed
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 1, 2026
Merged
pullBot pushed a commit to safarmer/flutter that referenced this pull request Jul 1, 2026
@engine-flutter-autoroll
Roll Packages from 274ed3e0f9f6 to e74210630ab8 (18 revisions) (flutt…
ca62cc7
…er#188863)
flutter/packages@274ed3e...e742106
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable
`tab_scaffold_test.dart` (flutter/packages#12064)
2026-07-01 jmccandless@google.com [material_ui] Port flutter/flutter
flutter#184808 "Remove semantics_tester import from card_test.dart"
(flutter/packages#11965)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`sliding_segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11979)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`route_test.dart` to `SemanticsHandle` (flutter/packages#11993)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`nav_bar_test.dart` to `SemanticsHandle` (flutter/packages#11980)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Migrate
`segmented_control_test.dart` to `SemanticsHandle`
(flutter/packages#11982)
2026-07-01 rmolivares@renzo-olivares.dev [cupertino_ui] Re-enable
`text_field_test.dart` (flutter/packages#12067)
2026-06-30 r.anantheswar@gmail.com [camera_android_camerax] Pass
targetVideoEncodingBitRate to Recorder (flutter/packages#11960)
2026-06-30 1063596+reidbaker@users.noreply.github.com
[camera_android_camerax] Migrate check-readiness skill from bash to Dart
(flutter/packages#11943)
2026-06-30 21270878+elliette@users.noreply.github.com [material_ui]
Enable `time_picker_test` (flutter/packages#12061)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Migrate checkbox_test.dart to SemanticsHandle (flutter/packages#12065)
2026-06-30 64674824+yashas-hm@users.noreply.github.com [image_picker]
Handle limit: 1 in pickMultiImage and pickMultipleMedia gracefully
(flutter/packages#11825)
2026-06-30 faheemabbas766@gmail.com [cross_file] Document native
mimeType behavior (flutter/packages#11662)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [material_ui]
Remove `image_data.dart` imports from `circle_avatar_test.dart`,
`color_scheme_test.dart` (flutter/packages#12059)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Remove `image_data.dart` import from `scaffold_test.dart`
(flutter/packages#12060)
2026-06-30 36861262+QuncCccccc@users.noreply.github.com [cupertino_ui]
Remove widgets import from menu_anchor_test.dart
(flutter/packages#12068)
2026-06-30 21270878+elliette@users.noreply.github.com [material_ui]
Enable `checkbox_list_tile_test` (flutter/packages#12007)
2026-06-30 louisehsu@google.com [in_app_purchase_storekit] Expose
quantity in Transactions (flutter/packages#11879)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmcjustinmcjustinmc approved these changes
@chunhtaichunhtaiAwaiting requested review from chunhtai
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: cupertino_uitriage-frameworkShould be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc@justinmc