Uh oh!
There was an error while loading. Please reload this page.
[google_sign_in_android] Keep default_web_client_id resource from being stripped by resource shrinker - #12075
Merged
Merged
Conversation
gmackall
marked this pull request as ready for review
July 30, 2026 19:28
gmackall
requested review from
a team, camsim99 and stuartmorgan-g
and removed request for
a teamJuly 30, 2026 19:28
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a keep.xml resource file to the Android implementation of the google_sign_in plugin to prevent the default_web_client_id resource from being stripped by resource shrinkers. It also updates the CHANGELOG.md and bumps the package version to 7.2.16 in pubspec.yaml. There are no review comments to address.
Uh oh!
There was an error while loading. Please reload this page.
Subhanshu20135 pushed a commit
to The-Developer-Diaries/flutter
that referenced
this pull request
Aug 3, 2026
…r#190441) flutter/packages@5351d8c...ac87e65 2026-07-31 developeryusuf@icloud.com [google_fonts] Remove failed loads from pendingFonts (flutter/packages#12240) 2026-07-31 34871572+gmackall@users.noreply.github.com [google_sign_in_android] Keep `default_web_client_id` resource from being stripped by resource shrinker (flutter/packages#12075) 2026-07-31 brunocorona.alcantar@gmail.com [vector_graphics] Provide textDirection for semantics label to avoid crash without Directionality (flutter/packages#11962) 2026-07-31 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Update `AGENTS.md` to improve video recording integration tests (flutter/packages#12301) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a keep rule for
@string/default_web_client_id, which gets merged into the main app's keep rules during the build.Fixesflutter/flutter#188363
Why this is needed
As documented in Customize which resources to keep:
The plugin retrieves
default_web_client_iddynamically viaResources.getIdentifier()inGoogleSignInPlugin.java:Without this keep rule, Android's resource shrinker discards
@string/default_web_client_idin release builds because there are no static bytecode references to the resource ID.