[google_fonts] Remove failed loads from pendingFonts

[Yusufihsangorgel]

Failed font loads remain in pendingFontFutures because the current cleanup
callback runs only after successful completion. As a result, every later
GoogleFonts.pendingFonts() call rethrows the same completed error.

This change removes a tracked load on either completion path while preserving
the original error for the caller currently awaiting pendingFonts(). It adds
regression coverage showing that the first call reports the load failure and a
later call is no longer poisoned by it.

Fixesflutter/flutter#182430.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩²

[gemini-code-assist]

Code Review

This pull request updates the google_fonts package to version 8.2.1. It ensures that failed font loads are removed from pendingFontFutures by replacing then with whenComplete on the loading future in google_fonts_base.dart. A unit test has been added to verify that pendingFonts correctly removes failed font loads. There are no review comments, and I have no feedback to provide.

[mafreud]

@Yusufihsangorgel Is this PR going to fix this issue?
material-foundation/flutter-packages#534

[guidezpl]

 _ ___ _____ __ __ | | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|

[Yusufihsangorgel]

Not directly. #534 is the load attempt itself failing (the fetch from fonts.gstatic.com throwing); after this PR that exception still happens once per failed load. What this PR fixes is one layer up: a failed load used to stay in pendingFontFutures, so every later GoogleFonts.pendingFonts() call rethrew the same completed error. If your Crashlytics noise is dominated by those repeats and the app uses pendingFonts(), this cuts it down to the single original failure; it does not prevent that first exception or add retrying.

[Yusufihsangorgel]

@guidezpl thanks for approving! The CICD label was never added, so presubmit is still waiting on Awaiting CICD label. Could you apply it when you get a chance?

[Piinks]

LGTM