Skip to content

[file_selector] Switch to Swift Testing - #12235

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
stuartmorgan-g:file-selector-swift-testing
Jul 28, 2026
Merged

[file_selector] Switch to Swift Testing#12235
auto-submit[bot] merged 4 commits into
flutter:mainfrom
stuartmorgan-g:file-selector-swift-testing

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Updates the iOS and macOS Swift unit tests to use Swift Testing rather than XCTest.

Part of flutter/flutter#180787

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Updates the iOS and macOS Swift unit tests to use Swift Testing rather
than XCTest.
Part of flutter/flutter#180787

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the iOS and macOS example runner tests for the file selector plugins from XCTest to the Swift Testing framework, replacing test classes, assertions, and expectations with @Suite, @Test, #expect, and confirmation. The review feedback recommends utilizing try #require(...) to safely unwrap optionals instead of force-unwrapping or using conditional binding, and simplifying array assertions to avoid potential out-of-bounds errors.

@okorohelijahokorohelijah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2026
@auto-submit
auto-submitBot merged commit b0d355f into flutter:mainJul 28, 2026
13 checks passed
navaronbracke pushed a commit to navaronbracke/flutter that referenced this pull request Jul 29, 2026
…er#190216)
flutter/packages@3e63635...dd11626
2026-07-29 stuartmorgan@google.com [pigeon] Clean up legacy registrant
code (flutter/packages#12205)
2026-07-29 me@davidmiguel.com [go_router] Add
BlockedInitialNavigationException for blocked initial deep links
(flutter/packages#12213)
2026-07-28 stuartmorgan@google.com [file_selector] Switch to Swift
Testing (flutter/packages#12235)
2026-07-28 269567208+reidbaker-agent@users.noreply.github.com Exempt
evals directories from version checks (flutter/packages#12299)
2026-07-28 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Migrate macros that contain `@tool`
(flutter/packages#12271)
2026-07-28 katelovett@google.com [material_ui, cupertino_ui] Fix API doc
references (flutter/packages#12274)
2026-07-28 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Delete `GeneratedCameraxLibrary.java`
(flutter/packages#12294)
2026-07-28 engine-flutter-autoroll@skia.org Roll Flutter from
9988960 to 0f02463 (16 revisions) (flutter/packages#12300)
2026-07-28 developeryusuf@icloud.com [vector_graphics_compiler] Ignore
unrecognized font-weight values (flutter/packages#12199)
2026-07-28 stuartmorgan@google.com [tool] Support promoting to 1.0 in
batch releases (flutter/packages#12262)
2026-07-28 1063596+reidbaker@users.noreply.github.com ci: Fix Zizmor
github-env failure in install_flutter action (flutter/packages#12298)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: file_selectorplatform-iosplatform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@okorohelijah